A few opportunities to make it better:
* It seems that the `ui-icon-admin` and `ui-icon-tool-*` CSS classes are unused
now except for `templates/widgets/project_summary.html` which is used in the
`[[projects]]` macro (FYI: they don't seem to work there in the sftheme, but do
in allura theme)
* custom icons don't show up there, so that template probably should be
changed similarly to what you did for `top_nav.html`
* then can we remove those CSS classes from our stylesheets?
* inline CSS isn't ideal, but I don't how to do it better .. maybe have a
dynamically generated CSS file that spits out `.ui-icon-tool-{{s.tool_name}} {
background-image: url({{ g.theme.app_icon_url((s.tool_name or 'admin').lower(),
32) }} }` for each tool? maybe need the pixel size (32) in the class name too?
* in which case we're re-defining the CSS classes and all the more reason
to remove the prior definitions
* It'd be nice if `icon_url()` didn't have to be overridden in each app that
isn't in Allura core. It's not doing anything particular special, just
boilerplate to use `g.forge_static`; the `icons` dict ideally is all each app
should have to specify. Not sure what it'd take to do that though. Change
core apps to use icon paths more in line with how pastebin does now?
---
** [tickets:#6942] Make custom tool icons work properly**
**Status:** in-progress
**Created:** Tue Dec 03, 2013 09:18 PM UTC by Tim Van Steenburgh
**Last Updated:** Tue Dec 03, 2013 09:28 PM UTC
**Owner:** Tim Van Steenburgh
There is currently no way for an external tool to provide a custom icon for the
top nav bar. https://sourceforge.net/p/allura/chat/2013/02/27/ provides a
thorough explanation of the problem. Fix this so that a custom tool can provide
it's own icons without needing to modify the theme (which is impractical).
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed
to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
