Very very nice. Minor remaining issues: * tests allura.tests.model.test_filesystem:TestFile.test_serve_embed[_false] fail. Maybe encoding change in last commit? * with multiple processes/hosts serving for one URL, won't g.server_start be out of sync between them and thus etag won't work well? For a production environment, the `build_key` config value could work (if deploy processes properly update that). But for development that doesn't get changed. Would an md5 of the CSS make sense? * locally I've removed the custom `def icon_url` from forgepastebin, and _icons.scss from sftheme, and its working fine.
--- ** [tickets:#6942] Make custom tool icons work properly** **Status:** in-progress **Created:** Tue Dec 03, 2013 09:18 PM UTC by Tim Van Steenburgh **Last Updated:** Fri Dec 13, 2013 05:09 AM UTC **Owner:** Tim Van Steenburgh There is currently no way for an external tool to provide a custom icon for the top nav bar. https://sourceforge.net/p/allura/chat/2013/02/27/ provides a thorough explanation of the problem. Fix this so that a custom tool can provide it's own icons without needing to modify the theme (which is impractical). --- Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
