Gene,
Try the attached patch.
Jean-Louis
Gene Heskett wrote:
On Wednesday 21 February 2007, Jean-Louis Martineau wrote:
Gene,
You found a bug.
Old debug files are not removed, this bug exist since we created subdir
for debugging files, only the root is cleaned.
Jean-Louis
I'd assume that similar code for the amanda-dbg assignment could be
patched in fairly easily? Maybe so simple as having the same code loop
twice, doing the dbg stuffs the second time? I might take a look, but no
patches promised unless I can do it pretty simply.
Thanks to you and Paul.
Gene Heskett wrote:
Greetings;
I just unpacked the 2.5.1p3-20070220 src tree and ran a grep
for 'amanda-dbg', finding it only in my gh.cf file that drives
the ./configure step. I expected that result as it hasn't been
configured yet, just unpacked.
Then I backed up to the 2.5.1p3-20070216 tree which is running right
now, and repeated the grep, finding dozens of places where it was
incorporated into the code. Except for server-src/amlogroll.c and
server-src/amtrmlog.c, its missing in those two files. Should it not
be included at least in amtrmlog? I would think it should be in both.
Is this one of those, gee, nobody noticed it before bugs?
diff -u -r --show-c-function --new-file --exclude-from=/home/martinea/src.orig/amanda.diff --ignore-matching-lines='$Id:' amanda-2.5.1p3/common-src/debug.c amanda-2.5.1p3.debug/common-src/debug.c
--- amanda-2.5.1p3/common-src/debug.c 2006-07-26 07:49:32.000000000 -0400
+++ amanda-2.5.1p3.debug/common-src/debug.c 2007-02-21 07:57:42.000000000 -0500
@@ -172,9 +172,9 @@ debug_setup_1(char *config, char *subdir
* We assume no system has 17 digit PID-s :-) and that there will
* not be a conflict between an old and new name.
*/
- if((d = opendir(AMANDA_DBGDIR)) == NULL) {
+ if((d = opendir(dbgdir)) == NULL) {
error("open debug directory \"%s\": %s",
- AMANDA_DBGDIR, strerror(errno));
+ dbgdir, strerror(errno));
/*NOTREACHED*/
}
time(&curtime);
