On Mon, May 13, 2019 at 16:53:22 +0000, Chris Hassell wrote:
> Where was this built?  Was it the default-from-debian?  I may pull
> that apart to see how they decided it should be built by default.

Yes, I have been wanting to suggest that as you work on cleaning up the
Amanda-provided Debian packaging you take a look at the official Debian
packaging and see if it would be possible to save yourself some trouble
by borrowing from the work already done there, and perhaps eliminate
some of the delta between your packaging and the official Debian ones.

One key difference that you presumably won't be able to eliminiate is
the choice of the username used to run Amanda (and thus own the
executable).  

(The Debian package has always used the "backup" user, which causes some
confusion for people used to the amanda.org/zmanda.com installation
instructions or prebuilt packages, but which was done for a good reason
[the "backup" user already exists on all Debian systems, so the Amanda
package does not have to worry about creating a user and setting file
ownerships to that user] and isn't likely to change now.)


But one thing that definitely seems worth checking is the
Build-Dependency list.  I haven't compared this with yours yet, but but
here is the list for the amanda_3.5.1-2.dsc package from Sid:

  Build-Depends: autotools-dev, bsd-mailx | mailx, curl, debhelper
                 (>=9), dh-autoreconf, dump [linux-any], flex, gawk,
                 gnuplot, libcurl4-openssl-dev, libglib2.0-dev,
                 libncurses5-dev, libreadline-dev, libssl-dev, libtool,
                 lpr, mtx, perl, po-debconf, procps, smbclient, swig,
                 xfsdump [linux-any]

One thing to note, though, is that this current build scripts assume a
release tarball (i.e. amanda_3.5.1.orig.tar.gz ), which already include
the manual pages as generated from source, so the Debian build does not
use the docbook-xsl/docbook-xml packages. 

Anyway, the place to look for Debian-specific changes would be in the
Salsa repository:
  https://salsa.debian.org/debian/amanda/debian

As a side note, the Debian package currently carries a handful of patches
unrelated to the build process, which presumably should be pushed
upstream as part of any 3.5.2 release.  I'll sent a separate email about
those.

                                                Nathan 


----------------------------------------------------------------------------
Nathan Stratton Treadway  -  [email protected]  -  Mid-Atlantic region
Ray Ontko & Co.  -  Software consulting services  -   http://www.ontko.com/
 GPG Key: http://www.ontko.com/~nathanst/gpg_key.txt   ID: 1023D/ECFB6239
 Key fingerprint = 6AD8 485E 20B9 5C71 231C  0C32 15F3 ADCD ECFB 6239

Reply via email to