> On Sept. 7, 2012, 12:34 p.m., Bart Cerneels wrote: > > src/core-impl/collections/daap/DaapMeta.cpp, line 43 > > <http://git.reviewboard.kde.org/r/106366/diff/2/?file=84097#file84097line43> > > > > Since the playable url now contains a session ID, I wonder if it will > > still be playable after restart. > > > > This might not be an issue if the track can be resolved using it's > > uidUrl by the DaapCollection the should become available not long after > > startup. > > Daniel Stöckel wrote: > I was about to say: "It definitely will not work" but this is not > entirely true. Apparently one can restart Amarok and still play a track > published by Rhythmbox. > However once Rhythmbox restarts the track can no longer be played. So it > basically comes down to the level of quirkiness on the server side. > > On the Amarok side a quick git grep told me that a DaapTrack is > instantiated at exactly one place: when downloading the TrackList from the > server. > Thus i do not think that any kind of resolving is actually taking place. > But still, i know basically nothing about the inner workings of Amarok.
Normally there is a CollectionManager::trackForUrl() call done when the playlist is restored from XSPF. The DaapCollection might not have been created yet at that point but a loader will then start listening for collectionAdded signals and try to resolve again. If there is some way to have a unique identifier for a DAAP resource that can be loaded again, replaying should be possible. If rythembox does not offer such unique ID it's their fault. - Bart ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106366/#review18654 ----------------------------------------------------------- On Sept. 7, 2012, 1:07 p.m., Daniel Stöckel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106366/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2012, 1:07 p.m.) > > > Review request for Amarok. > > > Description > ------- > > This simply sends a fake revision-number to the server. > > Also appends the session-id field to the track URLs. > > See: https://bugs.kde.org/show_bug.cgi?id=306351 > See: https://bugs.kde.org/show_bug.cgi?id=306351 > > > Diffs > ----- > > src/core-impl/collections/daap/DaapMeta.h 5278b57 > src/core-impl/collections/daap/DaapMeta.cpp a2429d7 > src/core-impl/collections/daap/daapreader/Reader.cpp b6196e1 > > Diff: http://git.reviewboard.kde.org/r/106366/diff/ > > > Testing > ------- > > - Rhythmbox collections now correctly appear and play in Amarok. > - Validated that mt-daap collections are still working. > > > Thanks, > > Daniel Stöckel > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
