----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106366/ -----------------------------------------------------------
(Updated Sept. 30, 2012, 7:28 p.m.) Review request for Amarok. Changes ------- Updated the patch. Removed Temporary change in CollectionManager and fixed indention in DaapCollection.cpp Description (updated) ------- This simply sends a fake revision-number to the server. Also appends the session-id field to the track URLs. See: https://bugs.kde.org/show_bug.cgi?id=306351 See: https://bugs.kde.org/show_bug.cgi?id=306351 Also implement trackForUrl and possiblyContainsTrack ind DaapCollection. This should allow reconnecting to daap servers that require authentication. However there seem to be problems with ConnectionManager which handles http urls as a special case. Also XSPFPlaylist uses the track.location instead of the track.identifier field when creating Meta::ProxyTracks. Thus using daap:// uidUrl as protocol (as in this patch) does have no effect. This addresses bug 306351. https://bugs.kde.org/show_bug.cgi?id=306351 Diffs (updated) ----- src/core-impl/collections/daap/DaapCollection.h f8655ec src/core-impl/collections/daap/DaapCollection.cpp 5d1bd9b src/core-impl/collections/daap/DaapMeta.h 9a9c257 src/core-impl/collections/daap/DaapMeta.cpp e66afb7 src/core-impl/collections/daap/daapreader/Reader.cpp b6196e1 Diff: http://git.reviewboard.kde.org/r/106366/diff/ Testing ------- - Rhythmbox collections now correctly appear and play in Amarok. - Validated that mt-daap collections are still working. Thanks, Daniel Stöckel
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
