[
https://issues.apache.org/jira/browse/AMBARI-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808029#comment-13808029
]
Nate Cole commented on AMBARI-3604:
-----------------------------------
Only a couple comments:
* this pattern should be visited soon, these values are coming out of Guice:
{noformat}
+ Clusters clusters = getManagementController().getClusters();
+ AmbariMetaInfo ambariMetaInfo =
getManagementController().getAmbariMetaInfo();
+ ServiceComponentFactory serviceComponentFactory =
getManagementController().getServiceComponentFactory();
{noformat}
If we had access to the injector, we can get any of these already-injected
members.
* Interchanging PropertyHelper.getPropertyId() for just static strings - is
this the pattern we should be taking for future code?
Patch +1, just wanted to bring some things up.
> Components in API should have 'category' field
> ----------------------------------------------
>
> Key: AMBARI-3604
> URL: https://issues.apache.org/jira/browse/AMBARI-3604
> Project: Ambari
> Issue Type: Bug
> Reporter: Tom Beerbower
> Assignee: Tom Beerbower
> Attachments: AMBARI-3604.patch
>
>
> Ambari UI when loading services, loads *all* host-components to get service
> specific metrics, which is available only on master host-components. Loading
> of client/worker host-components is not needed on dashboard and services
> pages.
> Hence in API we need a {{type}} field on host_components. This should
> indicate whether the host_component is master/worker/client/other type. Also,
> this field should be query-able.
> So the below query should give me services with their master host-components,
> and their jvm heap metrics.
> {code}
> http://162.216.149.155:8080/api/v1/clusters/ga/services?components/host_components/HostRoles/type=master&fields=components/ServiceComponentInfo,components/host_components,components/host_components/HostRoles,components/host_components/metrics/jvm/memHeapUsedM
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
