[
https://issues.apache.org/jira/browse/AMBARI-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808048#comment-13808048
]
Tom Beerbower commented on AMBARI-3604:
---------------------------------------
Thanks [~nc...@hortonworks.com].
* I agree on the injected members. I'm just trying to do the refactoring
incrementally. It seemed safer to me to add a few helper methods for the short
term than to worry about some case where a different injector gets used and
things get out of sync. I'll open another Jira to clean this up.
* In the initial design, PropertyHelper.getPropertyId() returned a PropertyId
class. It was decided that the class was unnecessary and that a string id
would suffice. Using the method is fine but may be confusing to people in that
it makes it look like property ids are more complex than just simple strings.
I've been removing usages of it.
> Components in API should have 'category' field
> ----------------------------------------------
>
> Key: AMBARI-3604
> URL: https://issues.apache.org/jira/browse/AMBARI-3604
> Project: Ambari
> Issue Type: Bug
> Reporter: Tom Beerbower
> Assignee: Tom Beerbower
> Attachments: AMBARI-3604.patch
>
>
> Ambari UI when loading services, loads *all* host-components to get service
> specific metrics, which is available only on master host-components. Loading
> of client/worker host-components is not needed on dashboard and services
> pages.
> Hence in API we need a {{type}} field on host_components. This should
> indicate whether the host_component is master/worker/client/other type. Also,
> this field should be query-able.
> So the below query should give me services with their master host-components,
> and their jvm heap metrics.
> {code}
> http://162.216.149.155:8080/api/v1/clusters/ga/services?components/host_components/HostRoles/type=master&fields=components/ServiceComponentInfo,components/host_components,components/host_components/HostRoles,components/host_components/metrics/jvm/memHeapUsedM
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
