I strongly don't agree that the base string calculation is a OAuthReuqest task, rather than is an issue has to be performed by Signing/Verifying methods. Since there is only one method to calculate the base string, it can be implemented in an abstract method implementation. That's how tests *already passed* on the original code base that we completely took off from the discussion - and that's not good :) Simo
http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Fri, Jul 9, 2010 at 12:22 PM, Pid <[email protected]> wrote: > On 09/07/2010 10:55, Simone Tripodi wrote: >> Hi, >> I just need few info about the OAuthRequest interface: >> >> - OAuthRequest#getSignatureBase(); just didn't understand what is it; > > A convenience method - it means the OAuthRequestImpl itself should know > how to generate the sig base string, just like it would know how to > generate it's toString method. > >> - OAuthRequest#setSignature(String signature); could be dropped since >> it could be translated as OAuthRequest#addOAuthMessageParameter(new >> OAuthMessageParameter(OAuthParameter.SIGNATURE, String value)); > > This is true - and more simple, i'll adjust my prototype to use your > method and remove that one. > > > p > >> Thanks in advance! >> Simo >> >> http://people.apache.org/~simonetripodi/ >> http://www.99soft.org/ > > >
