On 09/07/2010 11:31, Simone Tripodi wrote:
> I strongly don't agree that the base string calculation is a
> OAuthReuqest task, rather than is an issue has to be performed by
> Signing/Verifying methods.

OK, well, it's another way to look at it.

> Since there is only one method to calculate the base string, it can be
> implemented in an abstract method implementation.

Are you proposing that it's an entirely internal method then?
(I added it because I couldn't see it exposed anywhere.)



p

> 
> http://people.apache.org/~simonetripodi/
> http://www.99soft.org/
> 
> 
> 
> On Fri, Jul 9, 2010 at 12:22 PM, Pid <[email protected]> wrote:
>> On 09/07/2010 10:55, Simone Tripodi wrote:
>>> Hi,
>>> I just need few info about the OAuthRequest interface:
>>>
>>> - OAuthRequest#getSignatureBase(); just didn't understand what is it;
>>
>> A convenience method - it means the OAuthRequestImpl itself should know
>> how to generate the sig base string, just like it would know how to
>> generate it's toString method.
>>
>>> - OAuthRequest#setSignature(String signature); could be dropped since
>>> it could be translated as OAuthRequest#addOAuthMessageParameter(new
>>> OAuthMessageParameter(OAuthParameter.SIGNATURE, String value));
>>
>> This is true - and more simple, i'll adjust my prototype to use your
>> method and remove that one.
>>
>>
>> p
>>
>>> Thanks in advance!
>>> Simo
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://www.99soft.org/
>>
>>
>>


Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to