[ 
https://issues.apache.org/jira/browse/AMBER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529077#comment-13529077
 ] 

Antonio Sanso commented on AMBER-64:
------------------------------------

Thanks for your patch Stein I was going to apply your patch (because it makes 
sense to have) when  I have noticed we might need to handle the overall 
situation better. 
Let me explain we have a Junit test that cover this and did not fail (namely 
QueryParameterApplierTest ) and I was wondering why.

As outcome I have found a piece of code that doesn't cover this 

"The client MUST ignore unrecognized response parameters. " still from [0].

So it seems that any unrecognized parameter is currently bounced back and  that 
is not good IMHO
                
> QueryParameterApplier needs to include the scope parameter in the fragment
> --------------------------------------------------------------------------
>
>                 Key: AMBER-64
>                 URL: https://issues.apache.org/jira/browse/AMBER-64
>             Project: Amber
>          Issue Type: Bug
>            Reporter: Stein Welberg
>            Assignee: Antonio Sanso
>         Attachments: AMBER-64.patch
>
>
> According to the spec (see [0]) the scope parameter also needs to be included 
> in the url fragment if it is provided.
> Please find the patch attached to fix this attached to this issue.
> [0] http://tools.ietf.org/html/rfc6749#section-4.2.2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to