[ 
https://issues.apache.org/jira/browse/AMBER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557117#comment-13557117
 ] 

Antonio Sanso commented on AMBER-64:
------------------------------------

Hi Stein,

bq. With the current implementation of the QueryParametersApplier it is 
possible to have both variables in the fragment and as URL parameters.

Can you show an example?

After looking it carefully I did arrive to two conclusions:

1. the server will apply every request parameter and every fragment instructed 
in the code and is burden from the client to check them
2. I really think that in order to have a clean and working solution we need to 
change the API from 

public OAuthMessage applyOAuthParameters(OAuthMessage message, Map<String, 
Object> params) {

to

public OAuthMessage applyOAuthParameters(OAuthMessage message, Map<String, 
Object> params,Map<String, Object> fragments) {


WDYT?




                
> QueryParameterApplier needs to include the scope parameter in the fragment 
> ---------------------------------------------------------------------------
>
>                 Key: AMBER-64
>                 URL: https://issues.apache.org/jira/browse/AMBER-64
>             Project: Amber
>          Issue Type: Bug
>            Reporter: Stein Welberg
>            Assignee: Antonio Sanso
>             Fix For: 0.23
>
>         Attachments: AMBER-64_improved.patch
>
>
> According to the spec (see [0]) the scope parameter also needs to be included 
> in the url fragment if it is provided.
> Please find the patch attached to fix this attached to this issue.
> [0] http://tools.ietf.org/html/rfc6749#section-4.2.2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to