At least of hand that strongly looks like a bug.
Probably doesn't do much harm cause mutex_destroy() is mostly for
lockdep annotation, but still should be fixed.
Christian.
Am 29.09.2016 um 13:18 schrieb StDenis, Tom:
In this block of code I'm wondering if the mutex_destroy should be hoisted out
of the inner loop?
static void amdgpu_ctx_fini(struct amdgpu_ctx *ctx)
{
struct amdgpu_device *adev = ctx->adev;
unsigned i, j;
if (!adev)
return;
for (i = 0; i < AMDGPU_MAX_RINGS; ++i)
for (j = 0; j < amdgpu_sched_jobs; ++j) {
fence_put(ctx->rings[i].fences[j]);
mutex_destroy(&ctx->rings[i].sem_lock);
}
Cheers,
Tom
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
