Good catch, Could you make a patch?

Thanks,
David Zhou

On 2016年09月29日 19:18, StDenis, Tom wrote:
In this block of code I'm wondering if the mutex_destroy should be hoisted out 
of the inner loop?

static void amdgpu_ctx_fini(struct amdgpu_ctx *ctx)
{
         struct amdgpu_device *adev = ctx->adev;
         unsigned i, j;


         if (!adev)
                 return;


         for (i = 0; i < AMDGPU_MAX_RINGS; ++i)
                 for (j = 0; j < amdgpu_sched_jobs; ++j) {
                         fence_put(ctx->rings[i].fences[j]);
                         mutex_destroy(&ctx->rings[i].sem_lock);
                 }


Cheers,
Tom
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to