I would suggest to use RREG32_SOC15/ WREG32_SOC15 to avoid code refactor again...
Regards, Hawking -----Original Message----- From: amd-gfx [mailto:[email protected]] On Behalf Of Huang Rui Sent: Thursday, June 01, 2017 0:15 To: [email protected]; Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]> Cc: Wang, Ken <[email protected]>; Huang, Ray <[email protected]>; Huan, Alvin <[email protected]> Subject: [PATCH 00/18] Vega10 S3 following up Hi all, These patches refines gfxhub/mmhub programming sequence to make them clear and readable. And actually, gfxhub + mmhub = GMCv9 for vega10, we don't need specific gfxhub and mmhub ip blocks, and meanwhile, they have different resume sequence during gfxhub, mmhub, and gmc. That will make thing confused and easily miss some register configrations. So remove gfxhub and mmhub ip block here, and merge them into GMC v9. Patch 1 -> 8: refine gfxhub/mmhub programming sequence Patch 9: fix missed invalidation at resume Patch 10 -> 15: remove gfxhub/mmhub ip blocks Patch 16 -> 17: add prints to make ip_block mask clear. Patch 18: fix gart table cleared and other BOs cleared issue which blocked S3. (Extend stollen memory for VBIOS) Huang Rui (18): drm/amdgpu: abstract gart table initialization for gfxhub/mmhub drm/amdgpu: abstract gart aperture initialization for gfxhub/mmhub drm/amdgpu: abstract system aperture initialization for gfxhub/mmhub drm/amdgpu: abstract TLB initialization for gfxhub/mmhub drm/amdgpu: abstract cache initialization for gfxhub/mmhub drm/amdgpu: abstract system domain enablement for gfxhub/mmhub drm/amdgpu: abstract disable identity aperture for gfxhub/mmhub drm/amdgpu: abstract setup vmid config for gfxhub/mmhub drm/amdgpu: fix to miss program invalidation at resume drm/amdgpu: export gfxhub sw_init into gmc drm/amdgpu: export mmhub sw_init into gmc drm/amdgpu: export mmhub set clockgating into gmc drm/amdgpu: export mmhub get clockgating into gmc drm/amdgpu: remove gfxhub ip drm/amdgpu: remove mmhub ip drm/amdgpu: add ip name print for selecting ips with ip_block_mask drm/amdgpu: add ip block number prints drm/amdgpu: fix the gart table cleared issue for S3 drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 361 +++++++++++----------------- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.h | 1 + drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 2 + drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 2 + drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 2 + drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 18 +- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 373 ++++++++++++----------------- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.h | 4 + drivers/gpu/drm/amd/amdgpu/soc15.c | 2 - drivers/gpu/drm/amd/include/amd_shared.h | 2 - 13 files changed, 330 insertions(+), 448 deletions(-) -- 2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
