On 29/05/2026 11:30, Timur Kristóf wrote:
According to some SVM code this flag is necessary on
also GFX12.0 not just GFX12.1.

Signed-off-by: Timur Kristóf <[email protected]>
---
  drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c 
b/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c
index 586703ec0dfa0..7bbf5f848ce1b 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c
@@ -641,11 +641,12 @@ static int gmc_v12_0_early_init(struct amdgpu_ip_block 
*ip_block)
                adev->gmc.xgmi.connected_to_cpu =
                        adev->smuio.funcs->is_host_gpu_xgmi_supported(adev);
+ adev->gmc.init_pte_flags = AMDGPU_PTE_IS_PTE;
+
        switch (amdgpu_ip_version(adev, GC_HWIP, 0)) {
        case IP_VERSION(12, 1, 0):
                gmc_v12_1_set_gmc_funcs(adev);
                gmc_v12_1_set_irq_funcs(adev);
-               adev->gmc.init_pte_flags = AMDGPU_PTE_IS_PTE;
                break;
        default:
                gmc_v12_0_set_gmc_funcs(adev);

Code is fine but I don't have the inside knowledge to comment on the GFX12.0 vs GFX12.1 situation. Where is this SVM code commit message mentions?

Otherwise, maybe people who added this workaround could review? Those two are the relevant patches AFAICT:

commit db29ddf6505f3e831e000c95ae013b18a37f70bc
Author: Mukul Joshi <[email protected]>
Date:   Thu Apr 24 21:51:23 2025 -0400

    drm/amdgpu: Add per-ASIC PTE init flag


commit 9d47b2c36b9a6c6b844c33cab407a5d7ad102234
Author: Siwei He <[email protected]>
Date:   Tue Apr 14 14:46:54 2026 -0400

    drm/amdgpu: OR init_pte_flags into invalid leaf PTE update

I took the liberty to add some CCs.

Regards,

Tvrtko

Reply via email to