From: Ville Syrjälä <[email protected]>
The weird uapi semantics of the atomic async flip support make it
really hard for drivers to implement. Try to fix that by filtering
out the no-op junk from the commit that userspace likes to put there.
Also a lot of people are apparently confusing the
.atomic_async_{update,check}() hack with async flips. The two
are completely orthogonal, so try to clear up that mess by
renaming the hack to .atomic_bypass_{update,check}().
TODO: atomic+async is in serious need to proper tests, somehow
all that seems to have gotten skipped when the feature
was added :(
Cc: [email protected]
Cc: André Almeida <[email protected]>
Cc: Boris Brezillon <[email protected]>
Cc: Christopher Snowhill <[email protected]>
Cc: Dave Stevenson <[email protected]>
Cc: Dharma Balasubiramani <[email protected]>
Cc: Dmitry Baryshkov <[email protected]>
Cc: [email protected]
Cc: Gustavo Padovan <[email protected]>
Cc: Huacai Chen <[email protected]>
Cc: Icenowy Zheng <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Jianmin Lv <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: Liviu Dudau <[email protected]>
Cc: Maíra Canal <[email protected]>
Cc: Manikandan Muralidharan <[email protected]>
Cc: Maxime Ripard <[email protected]>
Cc: Mingcong Bai <[email protected]>
Cc: [email protected]
Cc: Qianhai Wu <[email protected]>
Cc: Raspberry Pi Kernel Maintenance <[email protected]>
Cc: Simon Ser <[email protected]>
Cc: [email protected]
Cc: Xaver Hugl <[email protected]>
Cc: Xi Ruoyao <[email protected]>
Ville Syrjälä (12):
drm/atomic: Remove tall tales about tearing vs. "async updates"
drm/atomic: s/async/bypass/
drm/atomic: Add FIXMEs around the incorrect use of the
.atomic_bypass_check() for async flips
drm/atomic: Highlight that bypass commits need care
drm/atomic/uapi: Eliminate the confusing
drm_atomic_check_prop_changes()
drm/atomic/uapi: Improve the async flip property rejection debugs
drm/atomic/uapi: Document the non-obvious fence/fb_id prop behaviour
drm/atomic/uapi: Add a FIXME about colorop vs. async flips
drm/atomic-helper: Mark drm_atomic_crtc_state_for_each_plane_state()
unsafe
drm/i915: Complete no-op "async flips" by hand
drm/atomic/uapi: Make async flips a bit more palatable through atomic
drm/atomic/uapi: Extract {connector,crtc,plane}_async_flip_check()
.clang-format | 2 +-
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 +-
.../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 20 +-
.../amd/display/amdgpu_dm/amdgpu_dm_plane.h | 6 +-
.../amd/display/amdgpu_dm/amdgpu_dm_trace.h | 16 +-
.../amdgpu_dm/tests/amdgpu_dm_plane_test.c | 32 +--
drivers/gpu/drm/arm/malidp_crtc.c | 6 +-
drivers/gpu/drm/drm_atomic.c | 97 ++++++++
drivers/gpu/drm/drm_atomic_helper.c | 49 ++---
drivers/gpu/drm/drm_atomic_uapi.c | 208 ++++++++++++++----
drivers/gpu/drm/drm_crtc_internal.h | 9 +
drivers/gpu/drm/drm_self_refresh_helper.c | 4 +-
drivers/gpu/drm/i915/display/i9xx_wm.c | 2 +-
drivers/gpu/drm/i915/display/intel_display.c | 38 ++++
drivers/gpu/drm/i915/display/intel_display.h | 4 +-
drivers/gpu/drm/loongson/lsdc_plane.c | 18 +-
drivers/gpu/drm/mediatek/mtk_plane.c | 12 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +-
drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 2 +-
drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 12 +-
drivers/gpu/drm/msm/msm_atomic.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 12 +-
drivers/gpu/drm/tegra/dc.c | 18 +-
drivers/gpu/drm/vc4/vc4_hvs.c | 2 +-
drivers/gpu/drm/vc4/vc4_plane.c | 16 +-
include/drm/drm_atomic.h | 10 +-
include/drm/drm_atomic_helper.h | 20 +-
include/drm/drm_modeset_helper_vtables.h | 50 +++--
29 files changed, 482 insertions(+), 201 deletions(-)
--
2.56.0