From: Ville Syrjälä <[email protected]> Document the fact that implementing bypass commits need actual care and attention to make sure the effective commit reordering is actually safe.
Cc: [email protected] Cc: André Almeida <[email protected]> Cc: Boris Brezillon <[email protected]> Cc: Christopher Snowhill <[email protected]> Cc: Dave Stevenson <[email protected]> Cc: Dharma Balasubiramani <[email protected]> Cc: Dmitry Baryshkov <[email protected]> Cc: [email protected] Cc: Gustavo Padovan <[email protected]> Cc: Huacai Chen <[email protected]> Cc: Icenowy Zheng <[email protected]> Cc: [email protected] Cc: [email protected] Cc: Jianmin Lv <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: Liviu Dudau <[email protected]> Cc: Maíra Canal <[email protected]> Cc: Manikandan Muralidharan <[email protected]> Cc: Maxime Ripard <[email protected]> Cc: Mingcong Bai <[email protected]> Cc: [email protected] Cc: Qianhai Wu <[email protected]> Cc: Raspberry Pi Kernel Maintenance <[email protected]> Cc: Simon Ser <[email protected]> Cc: [email protected] Cc: Xaver Hugl <[email protected]> Cc: Xi Ruoyao <[email protected]> Signed-off-by: Ville Syrjälä <[email protected]> --- include/drm/drm_modeset_helper_vtables.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h index d28d8ffc66b4..1036744b9922 100644 --- a/include/drm/drm_modeset_helper_vtables.h +++ b/include/drm/drm_modeset_helper_vtables.h @@ -1430,6 +1430,12 @@ struct drm_plane_helper_funcs { * given update can be committed bypassing the atomic commit machinery. * That is, if it can jump ahead of the state currently queued for update. * + * Extreme care is needed to make this safe as the already queued commits + * will not be aware of the bypass commit that overtook them. And the + * state that the bypass commit will observe is the final already queued + * state, not the current state at the point when the bypass commit + * will actually execute. + * * This function is also abused by drm_atomic_set_property() to determine * if the plane can be flipped in async. The flip flag is used to * distinguish if the function is used for just the plane state or for a -- 2.56.0
