Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/amdgpu: missing Fixes trailer for KFD read-only userptr bug in init_user_pages() --
commit 29a249e733b969cc649ffa369fb4f4e2387a5611 Author: Junhua Shen <[email protected]> > drm/amdgpu: map KFD userptr read-only when the BO is not writable > > init_user_pages() registers every userptr writable (flags = 0), ignoring > the KFD_IOC_ALLOC_MEM_FLAGS_WRITABLE flag that get_pte_flags() already > honors when mapping the BO. > > Pass AMDGPU_GEM_USERPTR_READONLY for a read-only allocation, so the > userptr registration matches the permission already enforced in the page > table. > > Signed-off-by: Junhua Shen <[email protected]> [Severity: Low] Should this include a Fixes: tag for the commit that introduced the hardcoded 0 flags argument in init_user_pages()? Fixes: 5ae0283e831a ("drm/amdgpu: Add userptr support for KFD") -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
