Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/amdkfd: missing Fixes trailer for commit 2f617f4df8df
--

commit 7d7f0cff270e1b2b262588e7979494905efa821e
Author: Junhua Shen <[email protected]>

> drm/amdkfd: honor KFD_IOCTL_SVM_FLAG_GPU_RO for read-only SVM ranges
>
> When mapping an SVM range, svm_range_validate_and_map() faults the pages
> with hmm_range_fault(), requesting write access unless the range is
> read-only. It decides read-only from the VMA write permission alone, so
> KFD_IOCTL_SVM_FLAG_GPU_RO is ignored and the range is faulted for write.
>
> svm_range_get_pte_flags() already honors GPU_RO for the page table; honor
> it for the fault too.
>
> Signed-off-by: Junhua Shen <[email protected]>

[Severity: Low]
Since this fixes the read-only calculation in svm_range_validate_and_map(),
should it include a Fixes tag?

  Fixes: 2f617f4df8df ("drm/amdkfd: map SVM range with correct access 
permission")

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=2

Reply via email to