On 7/31/19 11:39 AM, Evan Quan wrote: > Enable arcturus power profile retrieval and setting. > > Change-Id: I85447ba9ca7de8e197840f76ce3745363c4133a6 > Signed-off-by: Evan Quan <[email protected]> > --- > drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 69 ++++++++++++++++++++ > 1 file changed, 69 insertions(+) > > diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c > b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c > index c3f9487276c0..47d015035906 100644 > --- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c > +++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c > @@ -1503,6 +1503,73 @@ static int arcturus_get_power_limit(struct smu_context > *smu, > return 0; > } > > +static int arcturus_get_power_profile_mode(struct smu_context *smu, > + char *buf) > +{ > + static const char *profile_name[] = { > + "BOOTUP_DEFAULT", > + "3D_FULL_SCREEN", > + "POWER_SAVING", > + "VIDEO", > + "VR", > + "COMPUTE", > + "CUSTOM"}; > + uint32_t i, size = 0; > + int16_t workload_type = 0; > + > + if (!smu->pm_enabled || !buf) > + return -EINVAL; > + > + for (i = 0; i <= PP_SMC_POWER_PROFILE_CUSTOM; i++) { > + /* > + * Conv PP_SMC_POWER_PROFILE* to WORKLOAD_PPLIB_*_BIT > + * Not all profile modes are supported on arcturus. > + */ > + workload_type = smu_workload_get_type(smu, i); > + if (workload_type < 0) > + continue; > + > + size += sprintf(buf + size, "%2d %14s%s\n", > + i, profile_name[i], (i == smu->power_profile_mode) ? > "*" : " "); > + } > + > + return size; > +} > + > +static int arcturus_set_power_profile_mode(struct smu_context *smu, > + long *input, > + uint32_t size) > +{ > + int workload_type = 0; > + uint32_t profile_mode = input[size]; > + > + if (!smu->pm_enabled) > + return -EINVAL; > + > + if (profile_mode > PP_SMC_POWER_PROFILE_CUSTOM) { > + pr_err("Invalid power profile mode %d\n", profile_mode); > + return -EINVAL; > + } > + > + /* > + * Conv PP_SMC_POWER_PROFILE* to WORKLOAD_PPLIB_*_BIT > + * Not all profile modes are supported on arcturus. > + */ > + workload_type = smu_workload_get_type(smu, profile_mode); > + if (workload_type < 0) { > + pr_err("Unsupported power profile mode %d on arcturus\n", > profile_mode); > + return -EINVAL; > + } > + > + smu_send_smc_msg_with_param(smu, > + SMU_MSG_SetWorkloadMask, > + 1 << workload_type);
[kevin]: please d check return value, after send message succeed, then modify power_profile_mode value. if send message failed, you can't update power_profile_mode value. after fixed: Reviewed-by: Kevin Wang <[email protected]> > + > + smu->power_profile_mode = profile_mode; > + > + return 0; > +} > + > static void arcturus_dump_pptable(struct smu_context *smu) > { > struct smu_table_context *table_context = &smu->smu_table; > @@ -1968,6 +2035,8 @@ static const struct pptable_funcs arcturus_ppt_funcs = { > .force_dpm_limit_value = arcturus_force_dpm_limit_value, > .unforce_dpm_levels = arcturus_unforce_dpm_levels, > .get_profiling_clk_mask = arcturus_get_profiling_clk_mask, > + .get_power_profile_mode = arcturus_get_power_profile_mode, > + .set_power_profile_mode = arcturus_set_power_profile_mode, > /* debug (internal used) */ > .dump_pptable = arcturus_dump_pptable, > .get_power_limit = arcturus_get_power_limit, _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
