Code review: fileinstall.autoconf
---------------------------------
Key: AMDATU-507
URL: http://jira.amdatu.org/jira/browse/AMDATU-507
Project: Amdatu
Issue Type: Improvement
Components: Amdatu Core
Reporter: Jan Willem Janssen
Fix For: 0.3.0
My code review:
* redundant service-lifecycle methods (start/stop);
* the install/uninstall/update methods are using synchronized blocks icw
framework calls; possible deadlocks!
* the install/uninstall/update methods want to perform an atomic block, which
should be implemented in a different way (see Felix' AutoConfResourceProcessor
for example);
* possible resource leaks: new FileInputStreams are created, but never closed
properly;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
