[
http://jira.amdatu.org/jira/browse/AMDATU-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12287#comment-12287
]
Bram de Kruijff commented on AMDATU-507:
----------------------------------------
{quote}
redundant service-lifecycle methods (start/stop);
{quote}
Removed
{quote}
the install/uninstall/update methods are using synchronized blocks icw
framework calls; possible deadlocks!
the install/uninstall/update methods want to perform an atomic block, which
should be implemented in a different way (see Felix' AutoConfResourceProcessor
for example);
{quote}
I see a need for some kind of atomic blocks. Being aware of the fact that
FileInstall may be running concurrent threads, knowing that ResourceProcessor
is stateful and doesn't do funky OSGi stuff other then calling ConfigAdmin,
which in turn asynchronously calls others... ok, it is not ideal but I do not
understand your hint to a solution. please elaborate.
{quote}
possible resource leaks: new FileInputStreams are created, but never closed
properly;
{quote}
Resolved
> Code review: fileinstall.autoconf
> ---------------------------------
>
> Key: AMDATU-507
> URL: http://jira.amdatu.org/jira/browse/AMDATU-507
> Project: Amdatu
> Issue Type: Improvement
> Components: Amdatu Core
> Reporter: Jan Willem Janssen
> Assignee: Bram de Kruijff
> Labels: code_review
> Fix For: Sprint 2
>
>
> My code review:
> * redundant service-lifecycle methods (start/stop);
> * the install/uninstall/update methods are using synchronized blocks icw
> framework calls; possible deadlocks!
> * the install/uninstall/update methods want to perform an atomic block, which
> should be implemented in a different way (see Felix'
> AutoConfResourceProcessor for example);
> * possible resource leaks: new FileInputStreams are created, but never closed
> properly;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
