Code review: libraries.warsupport
---------------------------------
Key: AMDATU-516
URL: http://jira.amdatu.org/jira/browse/AMDATU-516
Project: Amdatu
Issue Type: Improvement
Components: Amdatu Core
Reporter: Jan Willem Janssen
Fix For: Backlog
My comments:
* StartupListener has a FIXME + JIRA call; is this "amdatu.contextpath" only
needed when Amdatu is running from a WAR? If so, why?
* FrameworkService relies upon a magic property: "amdatu.dir";
* FrameworkService seem to depend on a properties file (called
framework.properties); but where is this file taken from?
* FrameworkService#createConfig() & #relativeToAbsolute has System.out
statement, while there's a log-method available;
* ProvisionActivator#start seems to publish the BundleContext to the
ServletContext, but it is never read back?
* ProvisionActivator#start uses System.out statements, while there's a
log-method available (servlet context).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
