[
http://jira.amdatu.org/jira/browse/AMDATU-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12324#comment-12324
]
Jan Willem Janssen commented on AMDATU-507:
-------------------------------------------
Reviewed last changes (r2018), two tiny issues:
- executorService#shutdown() first executes all remaining tasks in its queue,
then shuts down. This *might* cause the stop method to block longer than
necessary. Maybe shutdownNow() should be used instead?
- both the Task-enum and ProcessorSession class can be made static.
> Code review: fileinstall.autoconf
> ---------------------------------
>
> Key: AMDATU-507
> URL: http://jira.amdatu.org/jira/browse/AMDATU-507
> Project: Amdatu
> Issue Type: Improvement
> Components: Amdatu Core
> Reporter: Jan Willem Janssen
> Assignee: Jan Willem Janssen
> Labels: code_review
> Fix For: Sprint 2
>
>
> My code review:
> * redundant service-lifecycle methods (start/stop);
> * the install/uninstall/update methods are using synchronized blocks icw
> framework calls; possible deadlocks!
> * the install/uninstall/update methods want to perform an atomic block, which
> should be implemented in a different way (see Felix'
> AutoConfResourceProcessor for example);
> * possible resource leaks: new FileInputStreams are created, but never closed
> properly;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
