[
http://jira.amdatu.org/jira/browse/AMDATU-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12390#comment-12390
]
Jan Willem Janssen commented on AMDATU-523:
-------------------------------------------
Just checked out the refactored code, still some questions left:
* What purpose does ParameterTenantResolverConstants have? It is not used at
all (apart from being a *marker* interface);
* ParameterTenantMappingRegistry should be renamed to TenantRegistry or
something similar, it has nothing to do with the parameters, and improves
readability;
* shouldn't the name of the parameter be configurable?
> Code review: web.tenantresolver.parameter
> -----------------------------------------
>
> Key: AMDATU-523
> URL: http://jira.amdatu.org/jira/browse/AMDATU-523
> Project: Amdatu
> Issue Type: Improvement
> Components: Amdatu Web
> Reporter: Jan Willem Janssen
> Assignee: Jan Willem Janssen
> Labels: code_review
> Fix For: Sprint 3
>
>
> My comments:
> * why is this method of tenant-resolving present? It should only be used with
> caution because it provides possible security issues;
> * please fix the mentioned TODO for the tenantId parameter, is I can now pass
> in something like 'tenant=*' for obtaining any tenant.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
