[
http://jira.amdatu.org/jira/browse/AMDATU-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12393#comment-12393
]
Bram de Kruijff commented on AMDATU-523:
----------------------------------------
{quote}
What purpose does ParameterTenantResolverConstants have? It is not used at all
(apart from being a marker interface);
{quote}
It's a Constants (renamed) class containing the key is uses for the Tenant
property. Just like the TenantConstants (to be renamed) interface in the Tenant
API design. Or are you arguing that as we have a class here we can just put in
on ParameterTenantResolverExtenderFilter?
{quote}
ParameterTenantMappingRegistry should be renamed to TenantRegistry or something
similar, it has nothing to do with the parameters, and improves readability;
{quote}
True, copy&paste naming... renamed
{quote}
shouldn't the name of the parameter be configurable?
{quote}
Maybe probably but that has nothing to do with code review or multi-tenancy.
For now it covers all known use cases. Therefore I propose to split of a change
request.
> Code review: web.tenantresolver.parameter
> -----------------------------------------
>
> Key: AMDATU-523
> URL: http://jira.amdatu.org/jira/browse/AMDATU-523
> Project: Amdatu
> Issue Type: Improvement
> Components: Amdatu Web
> Reporter: Jan Willem Janssen
> Assignee: Bram de Kruijff
> Labels: code_review
> Fix For: Sprint 3
>
>
> My comments:
> * why is this method of tenant-resolving present? It should only be used with
> caution because it provides possible security issues;
> * please fix the mentioned TODO for the tenantId parameter, is I can now pass
> in something like 'tenant=*' for obtaining any tenant.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
