[
http://jira.amdatu.org/jira/browse/AMDATU-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12391#comment-12391
]
Jan Willem Janssen commented on AMDATU-522:
-------------------------------------------
It wasn't reviewed again, yet:
* I believe that the entire registry is not directly necessary, as the server
name is "safe", and the hostnames are to be directly registered as service
properties, you can do this as well:
{code}
ServiceReference[] refs =
m_bundleContext.getServiceReferences(Tenant.class.getName(),
"(org.amdatu.web.hostnames=" + serverName + ")");
if (refs != null && refs.length > 0) {
// obtain tenant and do something nifty with it...
}
{code}
* (the above could also work for the Parameter resolver, I think)
* regarding the log-statements, it could be a matter of style; I'm always
reluctant to have methods log statements that don't really contribute to the
main functionality.
> Code review: web.tenantresolver.hostname
> ----------------------------------------
>
> Key: AMDATU-522
> URL: http://jira.amdatu.org/jira/browse/AMDATU-522
> Project: Amdatu
> Issue Type: Improvement
> Components: Amdatu Web
> Reporter: Jan Willem Janssen
> Assignee: Jan Willem Janssen
> Labels: code_review
> Fix For: Sprint 3
>
>
> My comment is:
> * HostnameTenantResolverExtenderFilter has redundant log-statements in its
> filter lifecycle methods.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
