[
http://jira.amdatu.org/jira/browse/AMDATU-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12396#comment-12396
]
Marcel Offermans commented on AMDATU-522:
-----------------------------------------
Some comments:
* I agree the ad-hoc lookups in the service registry are slower than keeping
your own "index". One side note is that the dependency manager currently has an
undocumented feature to add indices directly to the service registry,
dramatically speeding up lookups that match an index. By default we don't use
that feature in Amdatu though, so having a specialized "index" makes sense.
* Every callback is rerouted to updateMapping() which in turn contains logic to
detect if the change was an add, change or remove. I fail to see why this is
better than having three separate methods. I also fail to see how newMapping
would ever be "null".
> Code review: web.tenantresolver.hostname
> ----------------------------------------
>
> Key: AMDATU-522
> URL: http://jira.amdatu.org/jira/browse/AMDATU-522
> Project: Amdatu
> Issue Type: Improvement
> Components: Amdatu Web
> Reporter: Jan Willem Janssen
> Assignee: Jan Willem Janssen
> Labels: code_review
> Fix For: Sprint 3
>
>
> My comment is:
> * HostnameTenantResolverExtenderFilter has redundant log-statements in its
> filter lifecycle methods.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
