Hi,
I just commited a 'fix' to the commonly happening bug of the 'invalid
command name ::MSN::SB..."
I noticed they come from everywhere in the code, but the last two procs in
the stack trace are cmsn_reconnect and chatTo.
I checked, msn_reconnect is call only from chatTo.
chatTo either creates an SB, or makes sure the SB is still in a connected
state by calling cmsn_reconnect.
to use an old SB instead of creating a new one, it calls SBFor, which
itself does a if {catch [$sb cget -stat]} (the call that causes the
'invalid command' and thus makes sure that the SB command still exists...
problem is that it seems from the SBFor that checks for it to the
cmsn_reconnect, there is a race condition and the SB gets deleted at the
same time.
What I did to fix it is a
if { $sb == 0 || [catch {cmsn_reconnect $sb }] } {
createNewSB
...
cmsn_reconnect $sb
}
which means if there was no SB, it will enter the if and create a new one,
if there was an SB, it will call the cmsn_reconnect proc, if it failed to
reconnect it, it will enter the if, and create a new SB again and recall
cmsn_reconnect...
I hope it fixes the bug, I just want some of you to massively test playing
with chatwindows/SBs to make sure I didn't break anything.. the logic
seems right, I need someone to test the logic though...
Thanks,
KaKaRoTo
On Fri, 02 Dec 2005 22:10:25 -0500, Youness Alaoui
<[EMAIL PROTECTED]> wrote:
Hi,
I've been adding the "refuse video conversation and send webcam
invitation" thing, but I got into a problem...
imagine, you send a video conversation, it gets canceled, you get a
webcam invitation, you accept it, and bam, you're sending your webcam...
Where in the whole process did the other user ACCEPT your video
invitation ????
I'm tired and my gf is pissed at me because I was in front of the PC the
whole afternoon, so I'll leave the thinking to you... other than that, I
think that theorically, I've already done what we requested... I just
don't want to commit it...
KaKaRoTo
On Fri, 02 Dec 2005 21:46:41 -0500, Karol Krizka <[EMAIL PROTECTED]>
wrote:
On Friday 02 December 2005 08:32, Youness Alaoui wrote:
I do think it's a good idea, and should be a safe commit, so I suggest
we
do it. But I don't want little things to be added each time and we'd
end
up with no deadline for 0.95. So I say "do it if you want and have
time",
but if it's not done before we decide to get 0.95 out, we won't wait
for
it to be done.
Done, points to http://amsn.sf.net/skins.php which is the page that the
new
site has skins in. Currently it just forwards the browser to the skins
section in the PHPNuke.
Also the Skin dialog is a bit bigger than required. There is an empty
space
under the OK button the size of the button itself. Does anyone else
have it?
I tried to add a "Restart aMSN for new skins" label somewhere, but I am
not
sure where. Any suggestions? I was thinking having it in the title
beside
"Please select the skin you would like to use." Maybe have it appear
after
the user selects a new skin.
Finally for post 0.95, I think we should make the skin and plugin
dialog look
about the same. This isn't very hard as it requires mainly moving a
punch of
pack commands around. I'll add it to wiki.
Jerome, you said you wanted to review all previous mails on the subject
and see what's missing before the 0.95 release, did you do it ? if yes,
can we get a summary of it ? Iremember you forwarded some emails saying
"has it been done?", I'll look into that myself (too busy with the job
for
today, maybe tonight)
but if you ALREADY have a list, it would be nice to share it.
Thanks,
KaKaRoTo
--
KaKaRoTo
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel
