Very well done! the system include was done because webcamsn was using the libmimic library which was in a totally different directory, then we grouped it... good job on the .dsw/.dsp files, I forgot about it, thx for following up on it. about the launcher, great job!!! so much better than 'system("bin/wish.exe scripts/amsn")' btw, now, can't we change the 'scripts' into 'amsn' so it will be easier for the user who wants to update from svn, and because scripts/ is not only scripts, it contains a lot of binaries too... ? anyways, it's a minor issue. also, the code looks great, but I still have two comments : 1 - the amsn.ascii.exe is wrongly named, it should be ANSI, not ASCII.. two totally different things (AFAIK) 2 - we don't NEED an ansi + unicode bins, nor code, it should ALL be unicode and that's it! also, you should use GetModuleFilenameW to make sure the code works even if compiled non-ascii... also, you created a _T() define, no need, the T"blabla" already exists (T is for generic, which is unicode/ansi, depending)... and finally, you have a #if UNICODE for _T define, but you use wsprintf and you use lstrlen, etc... it should have been #if UNICODE sprintf/wsprintf strlen/lstrlen... the functions you called are only unicode... but that's IF you want to keep support for ANSI, which I think is not necessary... keep it up!
KKRT On Thu, Jul 13, 2006 at 03:31:21PM -0700, [EMAIL PROTECTED] wrote: > Revision: 7052 > Author: lephilousophe > Date: 2006-07-13 15:30:43 -0700 (Thu, 13 Jul 2006) > ViewCVS: http://svn.sourceforge.net/amsn/?rev=7052&view=rev > > Log Message: > ----------- > In branch too : > webcamsn.h: Why a system wide include ? It's in the same dir... > Added MSVC project files and remove .NET ones > New launcher > > Modified Paths: > -------------- > branches/0_96/amsn/utils/webcamsn/src/webcamsn.h > > Added Paths: > ----------- > branches/0_96/amsn/utils/TkCximage/src/TkCximage.dsp > branches/0_96/amsn/utils/TkCximage/src/TkCximage.dsw > branches/0_96/amsn/utils/webcamsn/src/Webcamsn.dsp > branches/0_96/amsn/utils/webcamsn/src/Webcamsn.dsw > branches/0_96/amsn/utils/windows/launcher/ > branches/0_96/amsn/utils/windows/launcher/amsn.ascii.exe > branches/0_96/amsn/utils/windows/launcher/amsn.ico > branches/0_96/amsn/utils/windows/launcher/amsn.rc > branches/0_96/amsn/utils/windows/launcher/amsn.unicode.exe > branches/0_96/amsn/utils/windows/launcher/launcher.cpp > branches/0_96/amsn/utils/windows/launcher/launcher.dsp > branches/0_96/amsn/utils/windows/launcher/launcher.dsw > branches/0_96/amsn/utils/windows/winflash/Winflash.dsp > branches/0_96/amsn/utils/windows/winflash/Winflash.dsw > branches/0_96/amsn/utils/windows/winutils/Winutils.dsp > branches/0_96/amsn/utils/windows/winutils/Winutils.dsw > > Removed Paths: > ------------- > branches/0_96/amsn/utils/TkCximage/src/CxImage/cximage.vcproj > branches/0_96/amsn/utils/TkCximage/src/TkCximage.sln > branches/0_96/amsn/utils/TkCximage/src/TkCximage.vcproj > branches/0_96/amsn/utils/windows/launcher/amsn.ascii.exe > branches/0_96/amsn/utils/windows/launcher/amsn.ico > branches/0_96/amsn/utils/windows/launcher/amsn.rc > branches/0_96/amsn/utils/windows/launcher/amsn.unicode.exe > branches/0_96/amsn/utils/windows/launcher/launcher.cpp > branches/0_96/amsn/utils/windows/launcher/launcher.dsp > branches/0_96/amsn/utils/windows/launcher/launcher.dsw ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel