square87 wrote :
> 2007/3/22, Philippe Valembois - Phil <[EMAIL PROTECTED]>:
>>
>> Hi,
>
> Hi Phil, thanks for the reply.
Hi,
>
>> I can't commit your patch you sent because it modifies many parts of the
>> newCL and it seems you didn't understood at all how it works now...
>
>
>
> My patch doesn't modifies many parts. There are only events, and
> splainf/sitalf font is stored in a variable. This is all.
> That events are fundamental to parse a nickname or psm (the nickarray
> event,
> as you can see, isn't a good choice)
> You see many changes, because in _drawing psm_ there is a similar thing:
>
> if {[::config::getKey psmplace] == 1 } {
> set parsedpsm [::smiley::parseMessageToList " - $psm" 1]
> instructions....
> }
> if {[::config::getKey psmplace] == 2 } {
> set parsedpsm [::smiley::parseMessageToList "\n$psm" 1]
> istructions.... (the same instruction)
> }
>
> and i changed it in a more clear code:
> set parsedpsm ""
> if {[::config::getKey psmplace] == 1 } {
> set parsedpsm [::smiley::parseMessageToList " - $psm" 1]
> } elseif {[::config::getKey psmplace] == 2 } {
> set parsedpsm [::smiley::parseMessageToList "\n$psm" 1]
> }
> istructions...
>
> but this is not important for the plugin, so you can ignore.
Parsing a nickname each time you display it isn't really good at all !
That will raise at least 4 events for each nickname to display with your
current system... Not really efficient compared to the current system
where we raise 1 event for all nicknames and after one event for each
modified nickname... Don't forget that parsing is a so time consuming...
>
>> I never said to use aMSNPlus I agree it should be in another plugin that
>> handles all colored nicks but you MUST look at how it currently works in
>> aMSNPlus as the newCL offers the way to modify colors...
>
>
> only colors at the moment and only with nickarray event, that is not really
> good.
Why isn't it good ? About fonts the current system can be easily
extended : wait for the end of the week end and you will see...
For PSMs it could be done in the same way that it is actually done for
nicknames...
>
>> About fonts, yes I know you will say that we can't modify fonts and it's
>> true, that shouldn't be done in a such way... Look at how colors work
>> now... With your modification, the font will be the same for all the
>> nickname... I don't think it's a clean way to do that. You must add a
>> tag font like there are the tags text and color.
>
>
> Please try before my plugin and the judge
Huh ? I never judged your plugin... I only judged the patch you want us
to apply and I think that's the job of developers here...
>
>> I hope you won't be take that too personally... I only want to keep a
>> clean design for this newCL.
>
>
> I only need a variable for font and 4 events (2 for nicks and 2 for
> psms, if
> we want to parse also psms...). I don't think that can stain the newCL.
> As I said before. Try my plugin,
As I already said that would imply too much performances issues... You
may have a good computer with a tiny list... Don't forget that M$N
allows more than 300 contacts (I can't remember the limit)...
>
> I uploaded the diff (with only essential things) and here you can find the
> plugin:
> http://in.solit.us/archives/download/15885
> You can apply this change locally on your pc, try the plugin and then you
> can say me what do you think about the plugin or what must be changed and
> what i didn't understand...
The link you provided doesn't work...
>
> Phil
>> PS If you have any question about how work nick coloring in aMSNPlus
>> don't hesitate to ask...
>
>
>
> Sorry for my English.
> Thanks for all.
> Square87
Phil
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel
