On Sun, 29 Apr 2007, Youness Alaoui wrote:
> Hi,
> can anyone check the use of the traydock ? look at the forum thread
> http://amsn-project.net/forums/viewtopic.php?t=3175
> it looks like rev 8486 broke the tray dock for many people, it's because the
> diff on that rev was adding a :
> if { [config::getKey dock] == 0 } {return }
> and I'm guessins that some people had the option set to 0 for some reason..
Yes, I had this too on my testaccount. No idea what's causing it though. I
manually set it to 1 and I'm having no problems...
> I just grepped and it looks like that variable is used at some places
> and now I'm thinking maybe it was used for something else...
Where is it used? I just grepped too (after the grepping I had done when I
readded the option) and got no results... we do have some other
dock-related config values, but not this one...
> it could also be that it was used before but wasn't a boolean value,
> like 0 means freedesktop, 1 meant gnomedock, 2 meant windows dock, -1
> meant disabled...
Yes, could be... I found this code:
if {[::config::getKey startontray]} {
if {[::config::getKey dock]!=0} {
wm state . withdrawn
set ishidden 1
} else {
wm state . iconic
}
} else {
wm state . normal
}
Does anyone remember where it was used?
> could someone please look into this and see what the variable is used
> for in the other files when you do a grep on it (do a grep on dock, then
> pipe it to a grep on config). If the variable is wrongly chosen, it
> should be renamed like 'enable_tray' or something else that isn't
> already used.
What do you mean exactly?
I had performed this search and it seems this variable didn't exist, and I
just tested again now. It was only used in the piece of code I pasted
above.
Viv
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel
