OK, done (var name changed too), can you test it on your WM pls?
On Thu, 3 May 2007, Youness Alaoui wrote:
> ok, here's the thing..
> if { [package require libtray] works AND [systemtray_exists] == 1 }
> look at trayicon.tcl to see how it's used, it's called only once and used as
> a variable, so you should probably
> reuse it.. also watch it, you MUST do == 1, because if there's no tray, it
> returns -1 (which would also evaluate
> to true if you just did a if [systemtray_exists] ... )
> second thing, look at dock.tcl (that's the old docking system, it was an
> executable that worked only for gnome
> and it communicated with amsn through sockets), there's a init_dock in there,
> that's the one that initializes
> (or closes) the current dock implementation, but there's a if { use_dock }
> left in there.. that's probably
> because we had a use_dock variable for whether or not to enable the docking
> and then the 'dock' variable to tell
> which type of docking system to use...
> that variable should probably be renamed to use_tray instead, this way we're
> sure we don't have that case where
> use_dock is false and the user can't get it to work...
> we should probably clean all that junk old code from there and make it
> right...
> btw, UnixDock and WinDock are also using the use_dock config key... a grep
> would be wise...
> (watch for some stuff I saw like :
> if { ![WinDock] } { ... }
> this should probably become if { [UnixDock] } { ... }
> because ![WinDock] means either we're on unix or means we disabled docking...
>
> Thanks viv!
> KKRT
>
> On Thu, May 03, 2007 at 08:36:22PM -0400, Youness Alaoui wrote:
> > I don't know, I'll tell you if I can verify this here.. maybe the package
> > require works but the command to
> > create the tray fails...
> >
> >
> > KKRT
> >
> > On Thu, May 03, 2007 at 11:24:32PM +0300, Vivia Nikolaidou wrote:
> > > On Thu, 3 May 2007, Youness Alaoui wrote:
> > >
> > > > oh.. I think I already answered that...
> > > > it's on starting up, if the 'startontray' option is enabled, it will
> > > > check, if we have a dock (tray), we
> > > > withdraw the main window, otherwise, we just minimize it..
> > > > This should become use_tray, but should also CHECK if the tray is
> > > > available and libtray is loaded and working,
> > > > etc.. otherwise you'd end up with an invisible window when you launch
> > > > amsn if you ever enable the startontray
> > > > option.. and you can't get your window back because it's withdrawn and
> > > > because there is no tray to make it
> > > > appear again...
> > >
> > > OK, good. How do we check if the tray is available? Is a [catch {package
> > > require libtray}] enough? For example, you work without a tray on your
> > > system. What does the package require return? If it loads OK but there's
> > > no tray, how can we check this?
> > >
> > > >
> > > > KKRT
> > > >
> > > > On Thu, May 03, 2007 at 11:07:50PM +0300, Vivia Nikolaidou wrote:
> > > > >
> > > > > Yes, I already said I have absolutely no idea what this means. I left
> > > > > it
> > > > > as it was. Bump: Does anyone know what the code below did?
> > > > >
> > > > > On Thu, 3 May 2007, Youness Alaoui wrote:
> > > > >
> > > > > > Thanks a lot viv!
> > > > > >
> > > > > > btw, the 'other place' is :
> > > > > > if {[::config::getKey startontray]} {
> > > > > > if {[::config::getKey dock]!=0} {
> > > > > > wm state . withdrawn
> > > > > > set ishidden 1
> > > > > > } else {
> > > > > > wm state . iconic
> > > > > > }
> > > > > > } else {
> > > > > > wm state . normal
> > > > > > }
> > > > > >
> > > > > >
> > > > > > in the amsn file.
> > > > > >
> > > > > >
> > > > > > On Thu, May 03, 2007 at 08:15:49PM +0300, Vivia Nikolaidou wrote:
> > > > > > > On Thu, 3 May 2007, Youness Alaoui wrote:
> > > > > > >
> > > > > > > > Yep, just as I remember it.. which is why I ask again.. can
> > > > > > > > someone
> > > > > > > > please rename it to something else, like enable_tray...
> > > > > > >
> > > > > > > Changed, now it's called use_tray
> > > > > > >
> > > > > > > > and also check what's that 'dock' option used for in the other
> > > > > > > > files..
> > > > > > >
> > > > > > > Nothing afaik
> > > > > > >
> > > > > > > -------------------------------------------------------------------------
> > > > > > > This SF.net email is sponsored by DB2 Express
> > > > > > > Download DB2 Express C - the FREE version of DB2 express and take
> > > > > > > control of your XML. No limits. Just data. Click to get it now.
> > > > > > > http://sourceforge.net/powerbar/db2/
> > > > > > > _______________________________________________
> > > > > > > Amsn-devel mailing list
> > > > > > > Amsn-devel@lists.sourceforge.net
> > > > > > > https://lists.sourceforge.net/lists/listinfo/amsn-devel
> > > > > >
> > > > > > -------------------------------------------------------------------------
> > > > > > This SF.net email is sponsored by DB2 Express
> > > > > > Download DB2 Express C - the FREE version of DB2 express and take
> > > > > > control of your XML. No limits. Just data. Click to get it now.
> > > > > > http://sourceforge.net/powerbar/db2/
> > > > > > _______________________________________________
> > > > > > Amsn-devel mailing list
> > > > > > Amsn-devel@lists.sourceforge.net
> > > > > > https://lists.sourceforge.net/lists/listinfo/amsn-devel
> > > > > >
> > > > >
> > > > >
> > > > > ---
> > > > >
> > > > > "Where is the life that we have lost in living?
> > > > > Where is the wisdom that we have lost in knowledge?
> > > > > Where is the knowledge that we have lost in information?"
> > > > >
> > > > > OEO;
> > > > >
> > > > >
> > > > > -------------------------------------------------------------------------
> > > > > This SF.net email is sponsored by DB2 Express
> > > > > Download DB2 Express C - the FREE version of DB2 express and take
> > > > > control of your XML. No limits. Just data. Click to get it now.
> > > > > http://sourceforge.net/powerbar/db2/
> > > > > _______________________________________________
> > > > > Amsn-devel mailing list
> > > > > Amsn-devel@lists.sourceforge.net
> > > > > https://lists.sourceforge.net/lists/listinfo/amsn-devel
> > > >
> > > > -------------------------------------------------------------------------
> > > > This SF.net email is sponsored by DB2 Express
> > > > Download DB2 Express C - the FREE version of DB2 express and take
> > > > control of your XML. No limits. Just data. Click to get it now.
> > > > http://sourceforge.net/powerbar/db2/
> > > > _______________________________________________
> > > > Amsn-devel mailing list
> > > > Amsn-devel@lists.sourceforge.net
> > > > https://lists.sourceforge.net/lists/listinfo/amsn-devel
> > > >
> > >
> > >
> > > ---
> > >
> > > "Where is the life that we have lost in living?
> > > Where is the wisdom that we have lost in knowledge?
> > > Where is the knowledge that we have lost in information?"
> > >
> > > OEO;
> > >
> > >
> > > -------------------------------------------------------------------------
> > > This SF.net email is sponsored by DB2 Express
> > > Download DB2 Express C - the FREE version of DB2 express and take
> > > control of your XML. No limits. Just data. Click to get it now.
> > > http://sourceforge.net/powerbar/db2/
> > > _______________________________________________
> > > Amsn-devel mailing list
> > > Amsn-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/amsn-devel
> >
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by DB2 Express
> > Download DB2 Express C - the FREE version of DB2 express and take
> > control of your XML. No limits. Just data. Click to get it now.
> > http://sourceforge.net/powerbar/db2/
> > _______________________________________________
> > Amsn-devel mailing list
> > Amsn-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/amsn-devel
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Amsn-devel mailing list
> Amsn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/amsn-devel
>
---
"Where is the life that we have lost in living?
Where is the wisdom that we have lost in knowledge?
Where is the knowledge that we have lost in information?"
OEO;
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel
