lol, no, not one diff per line :p but you did change a lot of stuff, every change that should be considered as a whole should be in a different file. one file for the dp thing, one file for the nick comparison, etc... I also noticed you removed the checks for the run_alarm, I didn't see it mentioned anywhere, that's also something that should be in a different file.. I was looking through the diff and was wondering why you removed the run_alarm lines while your diff should fix the getNick into getContactData. I saw it and was wondering if you moved it somewhere else, and I kept searching for it but the diff was too big so I couldn't find where you moved all the run_alarm. If it was in its own file, it would have been easier. I know it sucks, but imagine being at our place, it sucks even more... sorry dude..
KaKaRoTo On Sun, Dec 16, 2007 at 10:51:35AM +0000, square87 wrote: > uff... :P > but i changed only a proc and i write what I changed and why. > It's all about one ( 1 ) proc, should i send a diff file for every line? :P > I changed various things...ok but i explained what i changed and why, so you > can decide. > > For me, the codes to (download and) load a DP (if newDP != oldDP) should go > in another proc that it will be called also when we unblock users to check > if they have a different DP, without waiting that they change it or they > change them status... in this case i have to send two diffs, both procs and > diffs will be more simply to control. > > My diff file is only for changes in that proc and stop. > > In that proc i have done also some changes to draw notify window with canvas > style, but i didn't reported that changes because it depends from another > proc. The same for others bugs that i found and i don't reported yet. > > Have a nice day. > Square87 > ------------------------------------------------------------------------- > SF.Net email is sponsored by: > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services > for just about anything Open Source. > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > _______________________________________________ > Amsn-devel mailing list > Amsn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/amsn-devel ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel
