btw, square, since you're part of the team now, can you review and take care of this guy's patches ? :p seriously though, you're used to how I work now, so if you could reread all your diff to see if you think of something that isn't right before committing. thanks :)
KKRT On Mon, Dec 17, 2007 at 05:26:23PM +0000, square87 wrote: > 2007/12/17, Youness Alaoui <[EMAIL PROTECTED]>: > > > > oh man! not again! lol, ok, I'll check your diffs, but not now, when I > > wake up... > > Just let me comment below... > > > > ok, I understand you, but you are doing it completely wrong!!! what we do > > there is to SAVE the identifier of the new DP, if we don't do > > it, then it's like ignoring the fact that the user changed his DP.. > > imagine the case you said before.. so you're hidden, use changes > > his DP, etc... now you go online, you open a chat with him, you chat, > > etc.. you see his old DP, you never see his new DP, so you never > > know that he actually changed his DP (unless he changes his status), > > because without this abook::set, it means we ignore the fact that > > he changed his dp.. > > I understand your issue here, you go online, you look at your friend's > > property page, you see a 'loading dp' or whatever.. but it > > doesn't load it.. ok.. so what should be done? well, the real fix would be > > to make sure that when a user is unblocked, or when we > > change our status from offline/hidden to something else, then we should > > check all online and non blocked users to see if anyone has a > > DP for which the file doesn't exist, if yes, then try to load it. > > And by the way, the current code is still better, because you go online, > > open a chat, it will downlod the new DP, instead of just > > thinking he didn't change it. > > > > 1) i am not doing it completely wrong!!! > 2) I know what it will be the real fix, according my knowledge , as i said > in 2 (two) posts that part of that code should go in another proc because it > will be useful when we unblock an user and in other cases (just read old > posts, in this thread, you'll find that i say that), but i got no opinion > about that. > 3) You say: the current code is still better etc.... but i cannot open all > CWs to check if i have the last users DPs. > > And there should be also a check of size of DP in cache because sometimes (i > don't know why, because i didn't investigate about that) the size is 0 byte > and we try to load a DP of 0 byte it means: don't load anything. But we > should or fix the case when a dp with 0 byte is created or just remove it > and try to download it or better don't care about that. > Check in your cache you'll find png files of 0 byte. > Amen > Square87 > ------------------------------------------------------------------------- > SF.Net email is sponsored by: > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services > for just about anything Open Source. > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > _______________________________________________ > Amsn-devel mailing list > Amsn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/amsn-devel ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel
