On Mon, Jun 23, 2008 at 01:15:09PM -0400, Youness Alaoui wrote: > On Sun, Jun 22, 2008 at 03:08:57PM +0200, G.G. wrote: > > Hello amsn2 developers, i'm yahe! I'm an italian student and i'm now > > part of the team. I have a good knowledge of C and i'm > > currently focusing on python, so amsn2 is a great opportunity! See you > > soon on IRC, bye! > > Yahe > > > > hello yahe! > good to see you here! glad to have you on board. Thanks for > the commit!! :) > > take care > KaKaRoTo > >
Hi yahe, I just had time to review your commit and made a few fixes... I'm too tired to explain, so you can see what I did in the diffs of my latest commits on profile.py. very short : - the code seems good! thx! - aMSNProfilePlugin was renamed to aMSNPluginConfiguration as it seems more appropriate - a missing 'else' would have caused some bug issues if the os is not posix nor nt.. (who knows, it might be running on some weird machine someday...) - the inital profile directory was set but not used everywhere.. - I removed the 'profiles' subdirectory from it - made your elementTo/FromDict functions private methods instead. Next stuff I had on my mind was to remove the os.walk() for loadAllProfiles. and have the 'deleteProfile' code moved into 'Profile.rmdir' or something. the removeProfile would have a 'and_delete' arg which would call that. The profiles saved should be in ~/.amsn2/profiles.xml a file with the list of all profiles.. when you add a profile, you just redump all your profiles into that file (load it, add to it, dump, in case it was modified in the meantime by another instance). This will allow to have a "delete my profile but keep my settings/logs/etc..", it's also a cleaner solution that an os.walk. That's it for now.. time to sleep.. might comment again if I think of something during my sleep :p @drf_av: will review soon your stuff, sorry, too tired now! KaKaRoTo ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel
