Hi,
Great! is back again. By the way, please considerer to review this patch
I've created.
It changes the plain_emblem* names to online_emblem* to follow states names
and the other pixmaps names (busy_emblem*, away_emblem*). I've added as well
the offline_emblem: colorize the DP picture to grey is not enough, must have
it own emblem pixmap. And last, this fit correctly the DP of the contact
inside the pixmap emblem itself (right now does not).
It works perfectly (as far i've tested).
Cheers.
2009/6/26 Youness Alaoui <kakar...@kakaroto.homelinux.net>
> Hi,
> Thanks for reporting (saw your msg on irc, but you were gone).
> vivia's last patch to remove spaces support mistakenly also removed the
> option for dps in cl.. I've now put it back in latest SVN!
> thx
> KaKaRoTo
>
> On Fri, Jun 26, 2009 at 1:45 PM, Gustavo A. Díaz
> <gustavo.d...@gmail.com>wrote:
>
>> Hi guys,
>>
>> I wanted to ask, why in latest commits emblems were disabled?
>>
>> Cheers.
>>
>> 2009/6/11 Gustavo A. Díaz <gustavo.d...@gmail.com>
>>
>>> Sending this email again, since i think was blocked due the attachment
>>> size... sorry...
>>>
>>> 2009/6/10 Gustavo A. Díaz <gustavo.d...@gmail.com>
>>>
>>>> Hi,
>>>>
>>>> Well since i don't know the state of this, and Square is almost offline,
>>>> i just modified the example code he gave me, to fix/add the new emblems of
>>>> my skin and to add the offline_emblem* pixmaps (to not use a greyed
>>>> plain_emeblem as offline)
>>>> Other thing is, i wanted to change plain_emblem* image names to
>>>> online_emblems* but then amsn launched a bug when i did that. This is most
>>>> to follow the other emblems names. Can this be done?
>>>> And, can this code be tested to see if works good?
>>>> (attaching guicontactlist.tcl and settings.xml of my skin, since it has
>>>> 2 new lines for this to work and the offline_emblem* pixmaps)
>>>>
>>>> Cheers.
>>>>
>>>> 2009/5/27 Gustavo A. Díaz <gustavo.d...@gmail.com>
>>>>
>>>>> Hi,
>>>>>
>>>>> BTW Square, i've created the detailed emblems you needed (with the same
>>>>> style as the small ones). Are in the SVN of my skin.
>>>>>
>>>>> Cheers.
>>>>>
>>>>> 2009/4/28 square87 <squar...@gmail.com>
>>>>>
>>>>>> can we start to upload this skin in our repo?
>>>>>>
>>>>>> *Square87*
>>>>>>
>>>>>> 2009/4/28 Gustavo A. Díaz <gustavo.d...@gmail.com>
>>>>>>
>>>>>>> Hi KKRT,
>>>>>>>
>>>>>>> All new images being added to the skin of amsn, I'm designing all in
>>>>>>> the new version.
>>>>>>> You could dig it in: *svn://
>>>>>>> svn.tuxfamily.org/svnroot/amsnskins/amsnskins/trunk/Sapphire/2.5/new-skin/
>>>>>>> *
>>>>>>>
>>>>>>> Sorry for late response...
>>>>>>>
>>>>>>> Cheers.
>>>>>>>
>>>>>>> 2009/4/24 Youness Alaoui <kakar...@kakaroto.homelinux.net>
>>>>>>>
>>>>>>>> Hey Gus, btw, I know this is off topic, but could you upload us some
>>>>>>>> of the voipcontrols images? the current ones aren't very nice!
>>>>>>>> (especially
>>>>>>>> the hangup button, hehe)
>>>>>>>> Also I think that the 'call/hangup' image is inverted..., for
>>>>>>>> example, call is :
>>>>>>>> up arrow
>>>>>>>> phone with ear parts facing up.. (all slightly diagonal)
>>>>>>>> it should be :
>>>>>>>> phone with ear parts facing down
>>>>>>>> up arrow (all slightly diagonal)
>>>>>>>> and for hangup, it seems to be ok... or it could otherwise be :
>>>>>>>> down arrow
>>>>>>>> phone with ear parts facing down (all being vertical)
>>>>>>>> also maybe make the arrow+phone green/red depending on
>>>>>>>> call/hangup...
>>>>>>>> We might also need 'video call' buttons soon (since it actually woks
>>>>>>>> already!)
>>>>>>>> p.s: wrote this yesterday, forgot to press send :s ::(
>>>>>>>> Thanks!
>>>>>>>> KaKaRoTo
>>>>>>>>
>>>>>>>> On Wed, Apr 22, 2009 at 11:43 AM, Gustavo A. Díaz <
>>>>>>>> gustavo.d...@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> Should be like the big DP frame that aMSN has in the main Window
>>>>>>>>> (our DP on top), which is under the frame, in the middle rectangle,
>>>>>>>>> with it
>>>>>>>>> size (like a real picture frame).
>>>>>>>>>
>>>>>>>>> 2009/4/22 Youness Alaoui <kakar...@kakaroto.homelinux.net>
>>>>>>>>>
>>>>>>>>>> Ok cool
>>>>>>>>>> well basically, when you have the DP in the contact list, we want
>>>>>>>>>> a frame around it, currently, the frame is 1 pixel large because the
>>>>>>>>>> CL
>>>>>>>>>> resizes the DP to the size of the frame and it puts one on the
>>>>>>>>>> other.. if
>>>>>>>>>> Gus uses the DP frames shown here :
>>>>>>>>>> http://artistic.lnxteam.org/?p=477
>>>>>>>>>> then we'll have a big part of the DP being cropped.. so we would
>>>>>>>>>> need to actually have an option for top-left-corner and
>>>>>>>>>> top-right-corner and
>>>>>>>>>> bottom-left-corner and bottomr-right-corner from the DP frame for the
>>>>>>>>>> border, so we can have something like the DP frame Gus is suggesting
>>>>>>>>>> and the
>>>>>>>>>> DP would go inside of the frame, not under
>>>>>>>>>> it...<http://artistic.lnxteam.org/?p=477>
>>>>>>>>>> I hope you understood it now!
>>>>>>>>>> I *think* there are some other options in the settings.xml that
>>>>>>>>>> use the same thing for setting the border.
>>>>>>>>>> KaKaRoTo
>>>>>>>>>>
>>>>>>>>>> On Wed, Apr 22, 2009 at 4:22 AM, square87 <squar...@gmail.com>wrote:
>>>>>>>>>>
>>>>>>>>>>> I'll code it
>>>>>>>>>>>
>>>>>>>>>>> Youness, please, can you explain better the option?
>>>>>>>>>>> *
>>>>>>>>>>> Square87*
>>>>>>>>>>>
>>>>>>>>>>> 2009/4/21 Gustavo A. Díaz <gustavo.d...@gmail.com>
>>>>>>>>>>>
>>>>>>>>>>>> Also, I forgot...
>>>>>>>>>>>> Mobile users (which currently uses mobile.png pixmap) I think it
>>>>>>>>>>>> needs and emblem too in this mode. I say "I think" cause i don't
>>>>>>>>>>>> know how
>>>>>>>>>>>> WLM handles those users when offline. Since actually in aMSN, if
>>>>>>>>>>>> we enable
>>>>>>>>>>>> show the DP of the users, and we have mobile users, does not look
>>>>>>>>>>>> right.
>>>>>>>>>>>>
>>>>>>>>>>>> Correct if i am wrong... how WLM look like there?
>>>>>>>>>>>>
>>>>>>>>>>>> Cheers.
>>>>>>>>>>>>
>>>>>>>>>>>> 2009/4/21 Youness Alaoui <kakar...@kakaroto.homelinux.net>
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>
>>>>>>>>>>>>> I agree with it all.. I'd like to see some option in the
>>>>>>>>>>>>> skins's setting like "dp_in_cl_size"or something similar, also
>>>>>>>>>>>>> some options
>>>>>>>>>>>>> to say where (4 corners) of the 'dp frames' the dp should be...
>>>>>>>>>>>>>
>>>>>>>>>>>>> I also agree about the naming convention, it's confusing.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Who wants to code it ? :)
>>>>>>>>>>>>>
>>>>>>>>>>>>> KaKaRoTo
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Tue, Apr 21, 2009 at 3:22 PM, Gustavo A. Díaz <
>>>>>>>>>>>>> gustavo.d...@gmail.com> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi Guys,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Today I was redesigning the CL emblems which I think it needs
>>>>>>>>>>>>>> a modification in the actual code implementation of it. How is
>>>>>>>>>>>>>> like now, a
>>>>>>>>>>>>>> user/designer could never use a rounded pixmap, since the user
>>>>>>>>>>>>>> DP is always
>>>>>>>>>>>>>> square and it use the size of the emblem pixmap (Ex. if the
>>>>>>>>>>>>>> emblem pixmap is
>>>>>>>>>>>>>> 32px, the DP will be the same).
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> So, I've designed these:
>>>>>>>>>>>>>> http://artistic.lnxteam.org/?p=477(despite the Spanish post,
>>>>>>>>>>>>>> there you could see the images...)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> In this case, i think is a better way, the DP must fit the
>>>>>>>>>>>>>> middle rectagle, so that any designer could design a better
>>>>>>>>>>>>>> emblem pixmap.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Plus, another detail is that must exist a offline_emblem and
>>>>>>>>>>>>>> not to use the plain_emblem when contacts are offline (which
>>>>>>>>>>>>>> should be
>>>>>>>>>>>>>> called online_emblem to follow the others pixmaps names,
>>>>>>>>>>>>>> away_... busy_...),
>>>>>>>>>>>>>> like the one i've designed.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> What do you think?
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Cheers.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> --
>>>>>>>>>>>>>> Gustavo A. Díaz
>>>>>>>>>>>>>> GDNet Projects
>>>>>>>>>>>>>> www.gdnet.com.ar
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> ------------------------------------------------------------------------------
>>>>>>>>>>>>>> Stay on top of everything new and different, both inside and
>>>>>>>>>>>>>> around Java (TM) technology - register by April 22, and save
>>>>>>>>>>>>>> $200 on the JavaOne (SM) conference, June 2-5, 2009, San
>>>>>>>>>>>>>> Francisco.
>>>>>>>>>>>>>> 300 plus technical and hands-on sessions. Register today.
>>>>>>>>>>>>>> Use priority code J9JMT32. http://p.sf.net/sfu/p
>>>>>>>>>>>>>> _______________________________________________
>>>>>>>>>>>>>> Amsn-devel mailing list
>>>>>>>>>>>>>> Amsn-devel@lists.sourceforge.net
>>>>>>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/amsn-devel
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> ------------------------------------------------------------------------------
>>>>>>>>>>>>> Stay on top of everything new and different, both inside and
>>>>>>>>>>>>> around Java (TM) technology - register by April 22, and save
>>>>>>>>>>>>> $200 on the JavaOne (SM) conference, June 2-5, 2009, San
>>>>>>>>>>>>> Francisco.
>>>>>>>>>>>>> 300 plus technical and hands-on sessions. Register today.
>>>>>>>>>>>>> Use priority code J9JMT32. http://p.sf.net/sfu/p
>>>>>>>>>>>>> _______________________________________________
>>>>>>>>>>>>> Amsn-devel mailing list
>>>>>>>>>>>>> Amsn-devel@lists.sourceforge.net
>>>>>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/amsn-devel
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Gustavo A. Díaz
>>>>>>>>>>>> GDNet Projects
>>>>>>>>>>>> www.gdnet.com.ar
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> ------------------------------------------------------------------------------
>>>>>>>>>>>> Stay on top of everything new and different, both inside and
>>>>>>>>>>>> around Java (TM) technology - register by April 22, and save
>>>>>>>>>>>> $200 on the JavaOne (SM) conference, June 2-5, 2009, San
>>>>>>>>>>>> Francisco.
>>>>>>>>>>>> 300 plus technical and hands-on sessions. Register today.
>>>>>>>>>>>> Use priority code J9JMT32. http://p.sf.net/sfu/p
>>>>>>>>>>>> _______________________________________________
>>>>>>>>>>>> Amsn-devel mailing list
>>>>>>>>>>>> Amsn-devel@lists.sourceforge.net
>>>>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/amsn-devel
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> ------------------------------------------------------------------------------
>>>>>>>>>>> Stay on top of everything new and different, both inside and
>>>>>>>>>>> around Java (TM) technology - register by April 22, and save
>>>>>>>>>>> $200 on the JavaOne (SM) conference, June 2-5, 2009, San
>>>>>>>>>>> Francisco.
>>>>>>>>>>> 300 plus technical and hands-on sessions. Register today.
>>>>>>>>>>> Use priority code J9JMT32. http://p.sf.net/sfu/p
>>>>>>>>>>> _______________________________________________
>>>>>>>>>>> Amsn-devel mailing list
>>>>>>>>>>> Amsn-devel@lists.sourceforge.net
>>>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/amsn-devel
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> ------------------------------------------------------------------------------
>>>>>>>>>> Stay on top of everything new and different, both inside and
>>>>>>>>>> around Java (TM) technology - register by April 22, and save
>>>>>>>>>> $200 on the JavaOne (SM) conference, June 2-5, 2009, San
>>>>>>>>>> Francisco.
>>>>>>>>>> 300 plus technical and hands-on sessions. Register today.
>>>>>>>>>> Use priority code J9JMT32. http://p.sf.net/sfu/p
>>>>>>>>>> _______________________________________________
>>>>>>>>>> Amsn-devel mailing list
>>>>>>>>>> Amsn-devel@lists.sourceforge.net
>>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/amsn-devel
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Gustavo A. Díaz
>>>>>>>>> GDNet Projects
>>>>>>>>> www.gdnet.com.ar
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ------------------------------------------------------------------------------
>>>>>>>>> Stay on top of everything new and different, both inside and
>>>>>>>>> around Java (TM) technology - register by April 22, and save
>>>>>>>>> $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
>>>>>>>>> 300 plus technical and hands-on sessions. Register today.
>>>>>>>>> Use priority code J9JMT32. http://p.sf.net/sfu/p
>>>>>>>>> _______________________________________________
>>>>>>>>> Amsn-devel mailing list
>>>>>>>>> Amsn-devel@lists.sourceforge.net
>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/amsn-devel
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ------------------------------------------------------------------------------
>>>>>>>> Crystal Reports - New Free Runtime and 30 Day Trial
>>>>>>>> Check out the new simplified licensign option that enables unlimited
>>>>>>>> royalty-free distribution of the report engine for externally
>>>>>>>> facing
>>>>>>>> server and web deployment.
>>>>>>>> http://p.sf.net/sfu/businessobjects
>>>>>>>> _______________________________________________
>>>>>>>> Amsn-devel mailing list
>>>>>>>> Amsn-devel@lists.sourceforge.net
>>>>>>>> https://lists.sourceforge.net/lists/listinfo/amsn-devel
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Gustavo A. Díaz
>>>>>>> GDNet Projects
>>>>>>> www.gdnet.com.ar
>>>>>>>
>>>>>>>
>>>>>>> ------------------------------------------------------------------------------
>>>>>>> Register Now & Save for Velocity, the Web Performance & Operations
>>>>>>> Conference from O'Reilly Media. Velocity features a full day of
>>>>>>> expert-led, hands-on workshops and two days of sessions from industry
>>>>>>> leaders in dedicated Performance & Operations tracks. Use code
>>>>>>> vel09scf
>>>>>>> and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
>>>>>>> _______________________________________________
>>>>>>> Amsn-devel mailing list
>>>>>>> Amsn-devel@lists.sourceforge.net
>>>>>>> https://lists.sourceforge.net/lists/listinfo/amsn-devel
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> ------------------------------------------------------------------------------
>>>>>> Register Now & Save for Velocity, the Web Performance & Operations
>>>>>> Conference from O'Reilly Media. Velocity features a full day of
>>>>>> expert-led, hands-on workshops and two days of sessions from industry
>>>>>> leaders in dedicated Performance & Operations tracks. Use code
>>>>>> vel09scf
>>>>>> and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
>>>>>> _______________________________________________
>>>>>> Amsn-devel mailing list
>>>>>> Amsn-devel@lists.sourceforge.net
>>>>>> https://lists.sourceforge.net/lists/listinfo/amsn-devel
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Gustavo A. Díaz
>>>>> GDNet Projects
>>>>> www.gdnet.com.ar
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Gustavo A. Díaz
>>>> GDNet Projects
>>>> www.gdnet.com.ar
>>>>
>>>
>>>
>>>
>>> --
>>> Gustavo A. Díaz
>>> GDNet Projects
>>> www.gdnet.com.ar
>>>
>>
>>
>>
>> --
>> Gustavo A. Díaz
>> GDNet Projects
>> www.gdnet.com.ar
>>
>>
>> ------------------------------------------------------------------------------
>>
>> _______________________________________________
>> Amsn-devel mailing list
>> Amsn-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/amsn-devel
>>
>>
>
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> Amsn-devel mailing list
> Amsn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/amsn-devel
>
>
--
Gustavo A. Díaz
GDNet Projects
www.gdnet.com.ar
Index: guicontactlist.tcl
===================================================================
--- guicontactlist.tcl (revisión: 11282)
+++ guicontactlist.tcl (copia de trabajo)
@@ -118,8 +118,10 @@
::skin::setPixmap downleft box_downleft.gif
::skin::setPixmap down box_down.gif
::skin::setPixmap downright box_downright.gif
- ::skin::setPixmap plain_emblem plain_emblem.gif
- ::skin::setPixmap plain_emblem_detailedview plain_emblem_detailedview.gif
+ ::skin::setPixmap online_emblem online_emblem.gif
+ ::skin::setPixmap online_emblem_detailedview online_emblem_detailedview.gif
+ ::skin::setPixmap offline_emblem offline_emblem.gif
+ ::skin::setPixmap offline_emblem_detailedview offline_emblem_detailedview.gif
::skin::setPixmap away_emblem away_emblem.gif
::skin::setPixmap away_emblem_detailedview away_emblem_detailedview.gif
::skin::setPixmap busy_emblem busy_emblem.gif
@@ -1568,18 +1570,27 @@
} elseif {[::config::getKey show_contactdps_in_cl] == "1" &&
!([::abook::getContactData $email MOB] == "Y" && $state_code == "FLN")} {
set img [::skin::getLittleDisplayPictureName $email]_cl
-
- image create photo $img
+ # Modified to fit new DP emblems
+ #image create photo $img
+
if {!$show_detailed_view} {
- $img copy [::skin::getLittleDisplayPicture $email [image height [::skin::loadPixmap plain_emblem ]]]
+ # Modified to fit new DP emblems
+ #$img copy [::skin::getLittleDisplayPicture $email [image height [::skin::loadPixmap online_emblem ]]]
+ set height_emblem [image height [::skin::loadPixmap online_emblem ]]
+ image create photo $img -height $height_emblem -width $height_emblem
+
+ set x_dp_cl [::skin::getKey x_dp_cl]
+ set y_dp_cl [::skin::getKey y_dp_cl]
+ $img copy [::skin::getLittleDisplayPicture $email [expr {$height_emblem - ($y_dp_cl * 2)}] ] -to \
+ $x_dp_cl $y_dp_cl
# We can get a user "hidden" if you have yourself on your own CL and you use MSNP18+ with mpop
if { $state_code == "FLN" || $state_code == "HDN"} {
::picture::Colorize $img grey 0.5
- $img copy [::skin::loadPixmap plain_emblem]
+ $img copy [::skin::loadPixmap offline_emblem]
} elseif { $state_code == "NLN" } {
- $img copy [::skin::loadPixmap plain_emblem]
+ $img copy [::skin::loadPixmap online_emblem]
} else {
$img copy [::skin::loadPixmap [::MSN::stateToImage $state_code]_emblem]
}
@@ -1594,13 +1605,16 @@
$img copy [::skin::loadPixmap notinlist_emblem]
}
} else {
+ # Modified to fit new DP emblems
+ image create photo $img
+
$img copy [::skin::getLittleDisplayPicture $email 60]
if { $state_code == "FLN" || $state_code == "HDN"} {
::picture::Colorize $img grey 0.5
- $img copy [::skin::loadPixmap plain_emblem_detailedview]
+ $img copy [::skin::loadPixmap offline_emblem_detailedview]
} elseif { $state_code == "NLN" } {
- $img copy [::skin::loadPixmap plain_emblem_detailedview]
+ $img copy [::skin::loadPixmap online_emblem_detailedview]
} else {
$img copy [::skin::loadPixmap [::MSN::stateToImage $state_code]_emblem_detailedview]
}
@@ -2764,7 +2778,7 @@
}
}
} else {
- set dim [image height [::skin::loadPixmap plain_emblem ]]
+ set dim [image height [::skin::loadPixmap online_emblem ]]
foreach element [getContactList full] {
if {[lindex $element 0] eq "C" } {
::skin::getLittleDisplayPicture [lindex $element 1] $dim 1
------------------------------------------------------------------------------
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel
