I would vote for 'set file' rather than set dir... + use 'set file [file
join [::config::getKey nudgepluginpath] nudge.wav]" rather than do a
"$dir/nudge.wav"...
and also.. WTF!? the directory is stored in amsn config ???... (I know, it's
not your code)!!! config keys should only be used by amsn core.. plugins
should have their own config... also, for the dir path, it just needs to be
stored in a namespace variable, not stored in a permanent config key..
also note, that it's better to do [set dir [file dirname $filename]] rather
than [set dir [string range $filename 0 end-10]]... :p
anyways, patch seems good apart from that.. i'll show you how to commit it
later...
Thanks!
KaKaRoTo
On Wed, Feb 3, 2010 at 8:18 PM, Alexander Nestorov
<alexander...@gmail.com>wrote:
> As described here
> http://www.amsn-project.net/forums/index.php?topic=6086.0 the sound that
> the Nudge plugin will play
> is always the same (the path of the nudge.wav file is hardcoded). This
> patch will make the Nudge plugin search for the
> nudge.wav file from the current skin, and if there isn't any, play the
> nudge.wav file shiped with the plugin.
>
>
> --
> Alexander Nest
>
>
> ------------------------------------------------------------------------------
> The Planet: dedicated and managed hosting, cloud storage, colocation
> Stay online with enterprise data centers and the best network in the
> business
> Choose flexible plans and management services without long-term contracts
> Personal 24x7 support from experience hosting pros just a phone call away.
> http://p.sf.net/sfu/theplanet-com
> _______________________________________________
> Amsn-devel mailing list
> Amsn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/amsn-devel
>
>
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel
