The whole idea is to minimize the changes to the code in external/* such that it has the possibility to be merged back to its source. Which is better
a) use "#ifdef __ARM_ARCH_4T__" (which is standard to many people and already in Androids compilation line). or b) "#ifdef ANDROID", "#include <cpu-features.h>", "#endif", "#ifdef __ARM_HAVE_HALFWORD_MULTIPLY" (which is highly Android specific. ? I prefer a). Dianne Hackborn wrote: > I really don't see any reason to not use bionic in external. This > would not be the common case, because by definition external tends to > be things that exist outside of android so probably want to run > elsewhere. But whether or not they want to depend on bionic should > really be up to the owner of the external code. And for sure stuff in > external should be able to have patches on it to take advantage of > bionic or even all kinds of higher-level android-specific APIs (look > at web kit for example). > > On Mon, Apr 6, 2009 at 6:26 PM, Sean McNeil <[email protected] > <mailto:[email protected]>> wrote: > > > Hi Fredrik, > > IMO, external/* should not depend on bionic. > > Fredrik Markström wrote: > > What is the general opinion about the code in external (for example > > skia, libjpg), can it depend on bionic-specifics like cpu-features.h > > or should we try to keep the external stuff independent ? > > > > The specific question this time is if I'd better off using "#if > > !defined(__ARM_ARCH_4T__)" or "#if > > defined(__ARM_HAVE_HALFWORD_MULTIPLY)" in > external/skia/.../SkMath.h > > > > /Fredrik > > > > > > > > > > > > > > -- > Dianne Hackborn > Android framework engineer > [email protected] <mailto:[email protected]> > > Note: please don't send private questions to me, as I don't have time > to provide private support, and so won't reply to such e-mails. All > such questions should be posted on public forums, where I and others > can see and answer them. > > > > --~--~---------~--~----~------------~-------~--~----~ unsubscribe: [email protected] website: http://groups.google.com/group/android-porting -~----------~----~----~----~------~----~------~--~---
