[Sean McNeil <[email protected]>] > > The whole idea is to minimize the changes to the code in external/* such > that it has the possibility to be merged back to its source. Which is better > > a) use "#ifdef __ARM_ARCH_4T__" (which is standard to many people and > already in Androids compilation line). > or > b) "#ifdef ANDROID", "#include <cpu-features.h>", "#endif", "#ifdef > __ARM_HAVE_HALFWORD_MULTIPLY" (which is highly Android specific. > > ? > > I prefer a).
For most of the libraries in external/* this is definitely the way to go. Also, bionic really should look as much as possibly like a "standard" libc -- we should be careful not to expose internal-only headers or implementation details needlessly and avoid depending on the same. Brian --~--~---------~--~----~------------~-------~--~----~ unsubscribe: [email protected] website: http://groups.google.com/group/android-porting -~----------~----~----~----~------~----~------~--~---
