Hi, Wouter, finally, I have found some time to review your bpm4struts cartridge.
First of all, let me congratulate you to your documentation - it is first-class content! I was able to follow all the ideas behind the cartridge design quite easily. Thanks a lot! IMO, we can take the structure of your document as a kind of template for future cartridge documentation (1 Foreword, 2 How to install, 3 How to use, 4 Features, 5 Modeling, 6 UML model constraints, 7 Naming conventions) - complete, concise, easy to follow. We could extend it with a UML profile, too, just for even more clarity. I imported your sample model into Poseidon 2.0. The new version now shows stereotypes on action states, too. This helps understand what's going on. However, the new version has problems to keep the lines between decision or merge points and the other elements rectilinear. Looks quite ugly (at least when you're a fan of aesthetics like I am!). Some points arose during the review that I'd like to forward to you: * Why do you use state diagrams for the high level workflows? They feel right but why? :-) * In your document you describe your modeling constraints using a kind of EBNF. This is good because it makes people really think about what they do. My immediate idea was: For a future release of the cartridge, let's generate a few metamodel decorators so that the cartridge can enforce those modeling constraints at code generation time, using understandable error messages pinpointing the place in the model where the constraint was violated. * In one of your previous emails, you said that you cannot use bpm4struts together with other cartridges in the same run. Why is that? What's exactly the problem? Some points for improvement: * I really miss code generation for JSPs with input fields * Skeletal generation of the Application.properties file * Back and forth String-to-datatype conversion. How could these be done? The next steps: We should release this cartridge a.s.a.p in AndroMDA 2.x. * At the moment, this requires documentation in Anakia format - as far as I have understood, you're already working on this. * We should also solve the problem that bpm4strust needs a separate AndroMDA run. * We should adapt the car rental system model to use bpm4struts. This would require new, adapted JSPs - I think this is the main amount of work. Thanks for the moment! Ideas? Matthias --- Matthias Bohlen "Consulting that helps project teams to succeed..." http://www.mbohlen.de/ ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ Andromda-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/andromda-devel
