>From looking at the scripts, they assume that there is already a GH repo setup for the new module. So there are, at least, the additional steps of creating the GH repo and setting its security settings appropriately.
Also, I don't see where the original bower.json file is created in the release scripts; so I suspect that this might also be a manual step that needs to be done when adding a new module. Did I miss this in the scripts somewhere? If all the files really were generated correctly from scratch every time then we could prevent the problem we had with the last releases from occurring again by deleting the contents of the working folder after cloning before generating/copying in the appropriate files. This doesn't seem to be the case, so either we should do that or, instead, automate (or semi-automate and document) the process of adding a new module to the AngularJS project, so that it includes providing the appropriate index.js and bower.json files. My preference is to update the publication script to generate/copy all the correct files for a build on every run and make sure that we clean the folder before doing this. An aside: It is annoying to look at the diffs of the bower repositories when we alternate between releases of different branches since so much changes in each one. This may (I am not 100% up on the internals of git) also add unnecessarily to the size of the bower git repositories. In any case, how about we change the bower publishing process so that in addition to tagging these commits with the version number, we also ensure that they are added to an appropriate branch rather than master? What do you think? On 19 January 2015 at 11:25, Caitlin Potter <[email protected]> wrote: > All we need to do is add it to the publish scripts, it’s trivial > > On Jan 19, 2015, at 6:16 AM, Pete Bacon Darwin <[email protected]> > wrote: > > What is the process right now for creating a new module in the angular.js > repository? > > On 19 January 2015 at 10:49, Caitlin Potter <[email protected]> > wrote: > >> That’s exactly the reason why it should be in the release process, it’s >> much easier if it’s all dealt with in one place >> >> >> >> On Jan 19, 2015, at 5:34 AM, Pete Bacon Darwin <[email protected]> >> wrote: >> >> What is the benefit of this being in the build/release process? >> Can we not simply manually update the package.json and index.js in each >> of the "bower-angular*" repositories once to what they need to be and then >> leave them alone? >> The only thing that is a potential concern is if we create a new module >> that needs a bower repository - that it will also need to have its >> package.json and index.js tweaked - but I think that we should have a >> process for creating new modules any way, no? >> >> -- >> You received this message because you are subscribed to the Google Groups >> "AngularJS" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> Visit this group at http://groups.google.com/group/angular. >> For more options, visit https://groups.google.com/d/optout. >> >> >> > > -- You received this message because you are subscribed to the Google Groups "AngularJS" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/angular. For more options, visit https://groups.google.com/d/optout.
