Hi Michael, I put my comments inline.
Best regards Steffen > -----Original Message----- > From: Anima <anima-boun...@ietf.org> On Behalf Of Michael Richardson > Sent: Montag, 19. September 2022 17:50 > Subject: [Anima] comments on anima-brski-prm > > I should remind people that git hates trailing whitespace, and please > configure > your editors to remove. I use emacs, and I have some code I use, but most > editors now have an option. So some diffs you may see are just trailing space > removal, which I guess I could have done on main/master. I'll keep this in mind ;-) > > I made a whole bunch of small editorial fixes, which I collected at: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fpull%2F76&data=05%7C01%7Csteffen.fries%40siemens.com%7C1 > e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d55 > a%7C1%7C0%7C637991995576757266%7CUnknown%7CTWFpbGZsb3d8eyJWIj > oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C200 > 0%7C%7C%7C&sdata=BInW0h%2BcDEGeYEKXrsPC9bH5lulIeO3NFsC7fiRSO > Eo%3D&reserved=0 > (I didn't make all those changes on the 18th, there was a rebase in the > middle) > You may find that the rich diff at: > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fpull%2F76%2Ffiles%3Fshort_path%3D39089b2%23diff- > 39089b29400b74ce53b0f9b46cc0e8c08434b3518372da2bb356646768a1d56e& > amp;data=05%7C01%7Csteffen.fries%40siemens.com%7C1e3b4e1da3b64d7c39 > c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637 > 991995576757266%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC > JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C& > sdata=D8HognvCph6bT2gaA9FyNfTV%2BBLO0Mgg5uBakmVGbgc%3D&res > erved=0 > provides for easier review. > In many cases I just split up long paragraphs into more digestable parts. > Thanks, that definitely increases readability. > ** If it would help discussion for me to split these up into a bunch of > separate > ** pull requests, I can do that. > > I tweaked many of the diagrams so that aasvg would produce beautiful > HTML/PDF. Didn't know that, but it definitely looks better. > > I also opened the following issues: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fissues%2F75&data=05%7C01%7Csteffen.fries%40siemens.com%7 > C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d > 55a%7C1%7C0%7C637991995576913478%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 2000%7C%7C%7C&sdata=kIownLfpv8NHsWec0QlDX6JGe%2BSYY7LPKwDx > XIV%2BPoE%3D&reserved=0: misuse of mDNS > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fissues%2F74&data=05%7C01%7Csteffen.fries%40siemens.com%7 > C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d > 55a%7C1%7C0%7C637991995576913478%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 2000%7C%7C%7C&sdata=b3kAxL1qQi9869RrZI9KGxQ7rD6cDBkBJXwT4ACo > o7k%3D&reserved=0: what is the threat for registrar-agent mis-use > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fissues%2F73&data=05%7C01%7Csteffen.fries%40siemens.com%7 > C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d > 55a%7C1%7C0%7C637991995576913478%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 2000%7C%7C%7C&sdata=PiIO9RNg6aYPgBScPHL%2BqNiyllVtTg9kgGfwL% > 2F8UTjI%3D&reserved=0: pledge-status responses are cumullative right? > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fissues%2F72&data=05%7C01%7Csteffen.fries%40siemens.com%7 > C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d > 55a%7C1%7C0%7C637991995576913478%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 2000%7C%7C%7C&sdata=lPJkOeKI%2FrMTIT3kdwoYH09opqZzcGWP19zPZ > EgzEzc%3D&reserved=0: section 5.5 is foreshadowed/repeated > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fissues%2F71&data=05%7C01%7Csteffen.fries%40siemens.com%7 > C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d > 55a%7C1%7C0%7C637991995576913478%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 2000%7C%7C%7C&sdata=o4ofsd6h0Ee8o7FTSTCjw0oqRMNChuttyUyot%2 > BkzdyU%3D&reserved=0: more tweaks need for ts diagram > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fissues%2F70%3Awhy&data=05%7C01%7Csteffen.fries%40siemens. > com%7C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42 > e1495d55a%7C1%7C0%7C637991995576913478%7CUnknown%7CTWFpbGZsb3 > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3 > D%7C2000%7C%7C%7C&sdata=5I7Rc%2FnV2QqJlQd5yrEUHilxWKjGSUATy > 8MfkVDWq9w%3D&reserved=0 is certificate optional in section 5.5? We will address and discuss the issues. > two trivial questions I want to bring up here. > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fissues%2F67&data=05%7C01%7Csteffen.fries%40siemens.com%7 > C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d > 55a%7C1%7C0%7C637991995576913478%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 2000%7C%7C%7C&sdata=rqlw%2Fvk5bWr0yr%2B%2FY5Sc1Ytr4q1O6KOvQ > DSZatwLhhg%3D&reserved=0: > shorten the pledge end points We defined BRSKI-PRM in the first place to be close to BRSKI and thus used descriptive names for the endpoints. In the constraint BRSKI document shortened names have been specified. We intended the same approach for BRSKI-PRM- > > in constrained-voucher, we wind up shortening all the end-points, so I wonder > if > we shouldn't just shorten the ones used in PRM *now* so that they can work > with CoAP over BTLE, when we get to that stage? > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co > m%2Fanima-wg%2Fanima-brski- > prm%2Fissues%2F66&data=05%7C01%7Csteffen.fries%40siemens.com%7 > C1e3b4e1da3b64d7c39c608da9a56a8c2%7C38ae3bcd95794fd4addab42e1495d > 55a%7C1%7C0%7C637991995576913478%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 2000%7C%7C%7C&sdata=rGzWB8LNmAu9rNBVXK9wGNs0ucMJWsSFJswm > bME0Uek%3D&reserved=0: reference to registrar as LDevID(Reg) The > Registrar certificate is referred to as LDevID(Reg), and I'm not entirely > sure why. Yes, it could and probably should be issued by the Enterprise CA, > but I don't think it has to be. It's just the Registrar Certificate. It > actually should > have the cmcRA EKU set, so it's not just an ordinary LDevID. > Am I missing something here? Yes, right, the registrar certificate may be an EE certificate, as it may not be necessarily traced back to an IDevID. Also the setting of the id-kp-cmcRA EKU needs to be mentioned as to be handled in the same way as in RFC 8995 > > Hope to talk to you all on Tuesday evening. Yes, will be there. > > > -- > Michael Richardson <mcr+i...@sandelman.ca>, Sandelman Software Works -= > IPv6 IoT consulting =- > > _______________________________________________ Anima mailing list Anima@ietf.org https://www.ietf.org/mailman/listinfo/anima
