So we have some disagreement here, I would hold off on any style PRs. I find that style updates w/o having enforcement first will just be a waste of everyone's time as code will drift from the style as we accept PRs. It also breaks attribution and makes it harder for us to look at why/when was a code made in such a way, specially when judging new changes against that code. Aside from forcing many rebases for style reasons, not because bugs got fixed or features added (which already cause many PRs to need rebases).
Considering our current backlog and issues before us, I really don't want to spend time in minor style changes nor reviewing them. If some code is so bad as to be a great maintenance burden, I would consider a PR, for the rest I think we can live with extra or missing spaces around operators. I think we should look at style enforcement way before we even think about allowing for style only PRs and only after we have dealt with the many other issues I consider higher priority than this. -- Brian Coca -- You received this message because you are subscribed to the Google Groups "Ansible Project" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CAJ5XC8%3DzT2xXYFs_c%3DE9FWoh2PzEWM0-JOcuSkMSMSHcQH5N%2Bg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
