If it affects how code works, I do not consider it a style change it is a bugfix.
If they change unrelated sections as part of a fix, I consider that a style change, if the section was so bad it was unreadable, that is an acceptable change as I stated above. For the enforcement I agree, it s a lot easier with a clean base, but it is useless to cleanup the base and then have a thousand PRs which can 'dirty' it again. Without having an enforcement in place or to be put in place right after the style cleanup, it really makes little sense to me to go down this road. Aside from the attribution issues, which I don't see a way around, in many cases the nature of our code makes a lot of the linting and style checks give out false positives, specifically with modules. One solution would be to ignore certain types of issues, but that will also hide the actual real positives. I'm not against having a style guide and enforcing it, I just see pure style PRs as near useless at this point, if not counter productive. Also I think we should be putting our efforts elsewhere right now. -- You received this message because you are subscribed to the Google Groups "Ansible Project" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CAJ5XC8%3DA%2BaGc9r4BdvwbvCHJPdVjGh3o8WhmjCCLooMHg1fcjg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
