----- Original Message -----
From: "Bruce Atherton" <[EMAIL PROTECTED]>
> >Also, I was just briefly looking at the code to get a feel for it. I see
in
> >ContainsSelector.isSelected that it returns true without closing the
file.
> >I'm assuming that it should, right?
>
> It should always be closed by the finally block. The question for me in
> that code is whether catching an exception on close should throw an
> exception. If the close fails because the creation of the stream threw an
> exception, this throw may hide the real problem. OTOH, empty catch blocks
> are generally considered bad karma.
>
> What does the combined wisdom of the Ant Dev mailing list think about this
> situation?
Ummm, but:
return true;
won't drop into the finally, right?! :))
Erik
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
