Comment below. --DD -----Original Message----- From: Magesh Umasankar [mailto:[EMAIL PROTECTED] Sent: Sunday, December 01, 2002 6:38 PM To: [EMAIL PROTECTED] Subject: Re: Need feedback on intended SourceFileScanner change
Instead of having getLastModified in TargetObject, consider: public boolean isDirtyWhenComparedWith(Object src); or if the "WhenComparedWith" seems to be pedantic, public boolean isDirty(Object src); The FileTarget would compare using last modified time stamps and if target file is older than src file, this method would return false. Other implementations of TargetObject may choose different mechanisms to perform the comparison before saying that the target object is dirty or not. [DD] I like this abstraction. But would it work with a mapper that returned several files to check dirty status given the proposed single object signtature? As far as naming goes, the Object part in TargetObject seems pedantic to me. Since we have a Target.java already, how about naming it Targetable instead? [DD] I don't like that name personally. TargetObject seems designed exclusively for SourceFileScanner, and thus should relate to it by name. Something like SourceFileItem? Cheers, Magesh -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
