On Saturday 15 March 2003 19:28, you wrote: > Zoran Vasiljevic wrote: > > On Saturday 15 March 2003 18:45, you wrote: > > > > Agree. I have skipped thru code and, apart from some > > typecasts, I see no problems. > > Hmmm ... I added a bunch of typecasts to avoid warnings at compile time, > are you saying you had to add more or that you've taken some out? Most > were to cast int to size_t - the code uses size information as a signed > integer in some places (-1 as a flag) so simply changing the offending > vars to size_t caused new warnings to pop up.
I just had to add a couple. > > The warnings I was getting rid of had nothing to do with the > functionality I added, I just dislike our having code that generates > warnings and took the opportunity to clean it up while I was working on it. > Oh yes. This is what I usually do when looking at the code after some time. Here/there I just define -Wall and quite often I'm surprised with what sneaked into :-) > I would probably take the approach of adding a new command to ns_cache, > using servPtr == NULL as a flag seems a bit of a kludge. Most of the > code works on a cache pointer with no other context information, > implementing a true global cache will just involve adding a new proc to > use a static tcl hashtable to map the name to a cache pointer. You > initializing that hashtable and an associated static lock the first time > the module is loaded, and only the first time ... I see. Well, this is quite simple as well. I'll look into it and try to get it in the Tcl API as transparent as possible. Cheers, Zoran -- AOLserver - http://www.aolserver.com/ To Remove yourself from this list: http://www.aolserver.com/listserv.html List information and options: http://listserv.aol.com/
