On Wednesday 23 February 2005 18:59, Brett Schwarz wrote: > just a couple of suggestions, from a very quick first > look (it is hard too sifting through the TAB changes, > as Dossy said): > > 1) Tcl already has Tcl_GetBoolean...this could be used > instead of the boolean...I believe...no big deal > though > > 2) This might be a good time to start moving away from > Tcl_AppendResult...just a thought. This is for AS in > general. Note: there is also a Tcl_WrongNumArgs > function that probably could be used in a few places > too. > > 3) similar to 2), it might be a good time to start > moving to Obj based commands.
Actually this is what I will do. I was working on another module and decided to switch to the new coding style. I think it is a good time to do this for this file, as the changes I am adding require a lot of code reorganization. This is probably hard to see through the cvs diff due to the noise of the whitespace changes. The new complete file is at <http://rmadilo.com/m2/config-changes/nsd/config.c> tom jackson -- AOLserver - http://www.aolserver.com/ To Remove yourself from this list, simply send an email to <[EMAIL PROTECTED]> with the body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject: field of your email blank.
